feat(sync): Allow setting a custom Sliding Sync connection ID and timeline limit on RoomListService#6289
Conversation
…eline limit on `RoomListService` Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
5d2c04c to
69520be
Compare
Merging this PR will improve performance by 68.28%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | Restore session [memory store] |
282 ms | 167.6 ms | +68.28% |
Comparing Johennes:johannes/sync-service-customisation (5d2c04c) with main (acda2e8)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6289 +/- ##
=======================================
Coverage 89.91% 89.92%
=======================================
Files 374 374
Lines 102613 102651 +38
Branches 102613 102651 +38
=======================================
+ Hits 92267 92307 +40
- Misses 6783 6790 +7
+ Partials 3563 3554 -9 ☔ View full report in Codecov by Sentry. |
|
Thank you for the contribution.
Why is it useful? Why do you need a different name? |
We've ran into what we think is interference between the main app sync and the sync from our share extension where both tread on the same IIUC sharing the position isn't fully guarded by the cross-process lock, so maybe this is why. //.share_pos() // TODO: This is racy, needs cross-process lock :') |
This allows setting the roomlist service's connection ID and timeline limit over FFI. We've found this to be helpful when using the service from an iOS share extension simultaneously to the main app.
CHANGELOG.mdfiles.