feat(sync): Allow setting a custom Sliding Sync connection ID and timeline limit on RoomListService

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>

Author: Johennes

bindings/matrix-sdk-ffi/CHANGELOG.md

@@ -8,6 +8,8 @@ All notable changes to this project will be documented in this file.
 
 ### Bug Fixes
 
+- Allow setting a custom Sliding Sync connection ID and timeline limit on `RoomListService`.
+  ([#6289](https://github.com/matrix-org/matrix-rust-sdk/pull/?))
 - [**breaking**] `OtherState` properly supports redacted events that still have fields in the
   content. The following fields are no longer optional:
   - `federate` in `OtherState::RoomCreate`.

bindings/matrix-sdk-ffi/src/sync_service.rs

@@ -128,6 +128,26 @@ impl SyncServiceBuilder {
         Arc::new(Self { builder, ..this })
     }
 
+    /// Set a custom Sliding Sync connection ID for the room list service.
+    ///
+    /// By default "room-list" is used. Set a different value for secondary
+    /// processes such as iOS Share Extensions that are not meant to reuse the
+    /// main app's connection.
+    pub fn with_room_list_conn_id(self: Arc<Self>, conn_id: String) -> Arc<Self> {
+        let this = unwrap_or_clone_arc(self);
+        let builder = this.builder.with_room_list_conn_id(conn_id);
+        Arc::new(Self { builder, ..this })
+    }
+
+    /// Set a custom timeline limit for the room list service.
+    ///
+    /// When set, overrides the default timeline limit of 0.
+    pub fn with_room_list_timeline_limit(self: Arc<Self>, limit: u32) -> Arc<Self> {
+        let this = unwrap_or_clone_arc(self);
+        let builder = this.builder.with_room_list_timeline_limit(limit);
+        Arc::new(Self { builder, ..this })
+    }
+
     pub async fn finish(self: Arc<Self>) -> Result<Arc<SyncService>, ClientError> {
         let this = unwrap_or_clone_arc(self);
         Ok(Arc::new(SyncService {

crates/matrix-sdk-ui/CHANGELOG.md

@@ -8,6 +8,8 @@ All notable changes to this project will be documented in this file.
 
 ### Bug Fixes
 
+- Allow setting a custom Sliding Sync connection ID and timeline limit on `RoomListService`.
+  ([#6289](https://github.com/matrix-org/matrix-rust-sdk/pull/?))
 - Include secondary relations when re-initializing a threaded timeline after a lag.
   ([#6209](https://github.com/matrix-org/matrix-rust-sdk/pull/6209))
 - Ensure that the display name of a `Room` in a `NotificationStatus` coming 

crates/matrix-sdk-ui/src/room_list_service/mod.rs

@@ -105,6 +105,12 @@ const DEFAULT_REQUIRED_STATE: &[(StateEventType, &str)] = &[
 const DEFAULT_ROOM_SUBSCRIPTION_EXTRA_REQUIRED_STATE: &[(StateEventType, &str)] =
     &[(StateEventType::RoomPinnedEvents, "")];
 
+/// The default Sliding Sync connection ID for the room list service.
+pub(crate) const DEFAULT_ROOM_LIST_CONN_ID: &str = "room-list";
+
+/// The default timeline limit for the room list service.
+pub(crate) const DEFAULT_ROOM_LIST_TIMELINE_LIMIT: u32 = 1;
+
 /// The default `timeline_limit` value when used with room subscriptions.
 const DEFAULT_ROOM_SUBSCRIPTION_TIMELINE_LIMIT: u32 = 20;
 
@@ -133,16 +139,31 @@ impl RoomListService {
     /// to create one in this case using
     /// [`EncryptionSyncService`][crate::encryption_sync_service::EncryptionSyncService].
     pub async fn new(client: Client) -> Result<Self, Error> {
-        Self::new_with_share_pos(client, true).await
+        Self::new_with_share_pos(
+            client,
+            true,
+            DEFAULT_ROOM_LIST_CONN_ID,
+            DEFAULT_ROOM_LIST_TIMELINE_LIMIT,
+        )
+        .await
     }
 
-    /// Like [`RoomListService::new`] but with a flag to turn the
-    /// [`SlidingSyncBuilder::share_pos`] on and off.
+    /// Like [`RoomListService::new`] but with additional configuration options.
+    ///
+    /// - `share_pos`: en- or disables [`SlidingSyncBuilder::share_pos`] for
+    ///   cross-process position sharing.
+    /// - `conn_id`: the Sliding Sync connection ID
+    /// - `timeline_limit`: the timeline limit
     ///
     /// [`SlidingSyncBuilder::share_pos`]: matrix_sdk::sliding_sync::SlidingSyncBuilder::share_pos
-    pub async fn new_with_share_pos(client: Client, share_pos: bool) -> Result<Self, Error> {
+    pub async fn new_with_share_pos(
+        client: Client,
+        share_pos: bool,
+        conn_id: &str,
+        timeline_limit: u32,
+    ) -> Result<Self, Error> {
         let mut builder = client
-            .sliding_sync("room-list")
+            .sliding_sync(conn_id)
             .map_err(Error::SlidingSync)?
             .with_account_data_extension(
                 assign!(http::request::AccountData::default(), { enabled: Some(true) }),
@@ -200,7 +221,7 @@ impl RoomListService {
                         SlidingSyncMode::new_selective()
                             .add_range(ALL_ROOMS_DEFAULT_SELECTIVE_RANGE),
                     )
-                    .timeline_limit(1)
+                    .timeline_limit(timeline_limit)
                     .required_state(
                         DEFAULT_REQUIRED_STATE
                             .iter()

crates/matrix-sdk-ui/src/sync_service.rs

@@ -47,7 +47,9 @@ use tracing::{Instrument, Level, Span, error, info, instrument, trace, warn};
 
 use crate::{
     encryption_sync_service::{self, EncryptionSyncPermit, EncryptionSyncService},
-    room_list_service::{self, RoomListService},
+    room_list_service::{
+        self, DEFAULT_ROOM_LIST_CONN_ID, DEFAULT_ROOM_LIST_TIMELINE_LIMIT, RoomListService,
+    },
 };
 
 /// Current state of the application.
@@ -774,6 +776,15 @@ pub struct SyncServiceBuilder {
     /// [`SlidingSyncBuilder::share_pos`]: matrix_sdk::sliding_sync::SlidingSyncBuilder::share_pos
     with_share_pos: bool,
 
+    /// Custom connection ID for the room list service.
+    /// Defaults to "room-list". Use a different value for
+    /// secondary processes such as iOS share extensions that are not
+    /// meant to reuse the main app's connection.
+    room_list_conn_id: String,
+
+    /// Custom timeline limit for the room list service. Defaults to 1.
+    room_list_timeline_limit: u32,
+
     /// The parent tracing span to use for the tasks within this service.
     ///
     /// Normally this will be [`Span::none`], but it may be useful to assign a
@@ -784,7 +795,14 @@ pub struct SyncServiceBuilder {
 
 impl SyncServiceBuilder {
     fn new(client: Client) -> Self {
-        Self { client, with_offline_mode: false, with_share_pos: true, parent_span: Span::none() }
+        Self {
+            client,
+            with_offline_mode: false,
+            with_share_pos: true,
+            room_list_conn_id: DEFAULT_ROOM_LIST_CONN_ID.to_owned(),
+            room_list_timeline_limit: DEFAULT_ROOM_LIST_TIMELINE_LIMIT,
+            parent_span: Span::none(),
+        }
     }
 
     /// Enable the "offline" mode for the [`SyncService`].
@@ -804,6 +822,18 @@ impl SyncServiceBuilder {
         self
     }
 
+    /// Set a custom conn_id for the room list sliding sync connection.
+    pub fn with_room_list_conn_id(mut self, conn_id: String) -> Self {
+        self.room_list_conn_id = conn_id;
+        self
+    }
+
+    /// Set a custom timeline limit for the room list service.
+    pub fn with_room_list_timeline_limit(mut self, limit: u32) -> Self {
+        self.room_list_timeline_limit = limit;
+        self
+    }
+
     /// Set the parent tracing span to be used for the tasks within this
     /// service.
     pub fn with_parent_span(mut self, parent_span: Span) -> Self {
@@ -817,11 +847,24 @@ impl SyncServiceBuilder {
     /// the background. The resulting [`SyncService`] must be kept alive as long
     /// as the sliding syncs are supposed to run.
     pub async fn build(self) -> Result<SyncService, Error> {
-        let Self { client, with_offline_mode, with_share_pos, parent_span } = self;
+        let Self {
+            client,
+            with_offline_mode,
+            with_share_pos,
+            room_list_conn_id,
+            room_list_timeline_limit,
+            parent_span,
+        } = self;
 
         let encryption_sync_permit = Arc::new(AsyncMutex::new(EncryptionSyncPermit::new()));
 
-        let room_list = RoomListService::new_with_share_pos(client.clone(), with_share_pos).await?;
+        let room_list = RoomListService::new_with_share_pos(
+            client.clone(),
+            with_share_pos,
+            &room_list_conn_id,
+            room_list_timeline_limit,
+        )
+        .await?;
 
         let encryption_sync = Arc::new(EncryptionSyncService::new(client, None).await?);