Fix object reference arrows not hiding with per-object visibility#4455
Open
Aayushmaan-24 wants to merge 1 commit intomapeditor:masterfrom
Open
Fix object reference arrows not hiding with per-object visibility#4455Aayushmaan-24 wants to merge 1 commit intomapeditor:masterfrom
Aayushmaan-24 wants to merge 1 commit intomapeditor:masterfrom
Conversation
Object reference arrows were correctly hidden when hiding an entire layer, but remained visible when toggling the visibility of individual objects. The root cause was in addRemoveObjectReferences(): it checked objectGroup->isHidden() to skip hidden layers, but never checked object->isVisible() for individual objects. Additionally, when a MapObjectsChanged event was emitted for a visibility toggle, only syncOverlayItems() was called (which only syncs positions), so the arrows were never removed. Fix: - In addRemoveObjectReferences(), skip invisible source objects and skip creating arrows that point to invisible target objects. - In changeEvent(), when MapObjectsChanged carries VisibleProperty, call addRemoveObjectReferences() to rebuild arrows. Fixes mapeditor#4451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object reference arrows were correctly hidden when hiding an entire layer, but remained visible when toggling the visibility of individual objects.
The root cause was in addRemoveObjectReferences(): it checked objectGroup->isHidden() to skip hidden layers, but never checked object->isVisible() for individual objects. Additionally, when a MapObjectsChanged event was emitted for a visibility toggle, only syncOverlayItems() was called (which only syncs positions), so the arrows were never removed.
Fix:
Fixes #4451