objects reference arrows still draw despite object toggled hidden

[jestarray]

Describe the bug

Notice how all objects are hidden but it's still drawing the object reference arrows .

Here is the full map file if needed:

tiled json file

{ "compressionlevel":-1,
 "height":1,
 "infinite":false,
 "layers":[
        {
         "data":[0],
         "height":1,
         "id":1,
         "name":"Tile Layer 1",
         "opacity":1,
         "type":"tilelayer",
         "visible":true,
         "width":1,
         "x":0,
         "y":0
        },
    
        {
         "draworder":"topdown",
         "id":3,
         "name":"Object Layer 2",
         "objects":[
                {
                 "height":0,
                 "id":4,
                 "name":"point",
                 "opacity":1,
                 "point":true,
                 "rotation":0,
                 "type":"",
                 "visible":true,
                 "width":0,
                 "x":24,
                 "y":0
                }],
         "opacity":1,
         "type":"objectgroup",
         "visible":true,
         "x":0,
         "y":0
        },
    
        {
         "draworder":"topdown",
         "id":2,
         "name":"Object Layer 1",
         "objects":[
                {
                 "height":24,
                 "id":1,
                 "name":"obj1",
                 "opacity":1,
                 "properties":[
                        {
                         "name":"anims",
                         "type":"list",
                         "value":[
                                {
                                 "type":"string",
                                 "value":"foo"
                                },
                            
                                {
                                 "type":"int",
                                 "value":3
                                },
                            
                                {
                                 "type":"bool",
                                 "value":false
                                },
                            
                                {
                                 "type":"object",
                                 "value":2
                                },
                            
                                {
                                 "type":"object",
                                 "value":3
                                }]
                        },
                    
                        {
                         "name":"test",
                         "type":"int",
                         "value":1
                        }],
                 "rotation":0,
                 "type":"",
                 "visible":true,
                 "width":24,
                 "x":8,
                 "y":8
                },
            
                {
                 "height":0,
                 "id":2,
                 "name":"obj2",
                 "opacity":1,
                 "rotation":0,
                 "type":"",
                 "visible":true,
                 "width":0,
                 "x":0,
                 "y":0
                },
            
                {
                 "height":0,
                 "id":3,
                 "name":"obj3",
                 "opacity":1,
                 "rotation":0,
                 "type":"",
                 "visible":true,
                 "width":0,
                 "x":-8,
                 "y":24
                }],
         "opacity":1,
         "type":"objectgroup",
         "visible":true,
         "x":0,
         "y":0
        }],
 "nextlayerid":4,
 "nextobjectid":5,
 "orientation":"orthogonal",
 "renderorder":"right-up",
 "tiledversion":"1.12.0",
 "tileheight":32,
 "tilesets":[],
 "tilewidth":32,
 "type":"map",
 "version":"1.11",
 "width":1
}

Steps to reproduce

1. Create an object with reference arrows to other objects
2. Toggle their visibility off

Expected behavior

Object reference arrows should be hidden if the object visibility is also hidden. Turning visibility of the entire layer off seems to turn off the object reference arrows though

OS version

archlinux on sway/wayland

Tiled version

1.12

[Aayushmaan-24]

Id like to work on this. The issue arises likely because

In objectselectionitem.cpp, the addRemoveObjectReferences() function iterates the map to build arrow items. It correctly skips hidden layers via objectGroup->isHidden(), but never checks object->isVisible() for individual objects.

Fix would involve

• The loop over objects should skip any object where object->isVisible() is false.
• When objects change, refresh reference items visibility.

I'll try to reproduce the issue and verify using the same JSON file provided.

[Aayushmaan-24]

I have made the changes here's how it is now
#4455