Skip to content

Makefile: separate local lint from generated checks #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suhas-developer07 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Makefile: separate local lint from generated checks #4549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03b3eff
Makefile: separate local lint from generated checks
suhas-developer07 Jan 27, 2026
1e69358
Makefile: separate local lint from generated checks
suhas-developer07 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,18 @@ lint: check-generated
ltag -t ./hack/ltag --check -v
protolint .

.PHONY: lint-local
lint-local:
golangci-lint run ./...
yamllint .
ls-lint
find . -name '*.sh' ! -path "./.git/*" | xargs shellcheck
find . -name '*.sh' ! -path "./.git/*" | xargs shfmt -s -d
go-licenses check --include_tests ./... --allowed_licenses=$$(cat ./hack/allowed-licenses.txt)
ltag -t ./hack/ltag --check -v
protolint .

Copy link
Member

@AkihiroSuda AkihiroSuda Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code clone has to be eliminated

Copy link
Member

@AkihiroSuda AkihiroSuda Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just decouple make lint from make check-generated and call it a day?


.PHONY: clean
clean:
rm -rf _output vendor
Expand Down Expand Up @@ -708,4 +720,4 @@ MKDIR_TARGETS += _artifacts
# This target must be placed after any changes to the `MKDIR_TARGETS` variable.
# It seems that variable expansion in Makefile targets is not done recursively.
$(MKDIR_TARGETS):
mkdir -p $@
mkdir -p $@
Loading