Makefile: separate local lint from generated checks

[suhas-developer07]

Summary

This PR separates local linting from CI enforcement.

Changes

• make lint now runs linters without requiring a clean git diff
• make lint-ci enforces check-generated before linting
• CI behavior remains strict and unchanged

Context

This addresses the developer experience issue raised in #3994 while preserving the reproducibility guarantees introduced in #3956.

Notes

Local protolint failures on generated files are unchanged and out of scope for this PR.

[AkihiroSuda]

Doesn't seem executed on CI?

Anyway, probably this target is not needed and you can just run make check-generated and make lint on CI instead

[afbjorklund]

Then again, "check-generated" is the one that is failing if you have made any changes (not only to protobuf)

.PHONY: lint
lint: check-generated

So that would make the whole thing a no-op, and you could just leave it the way it was - at least for CI.

[afbjorklund]

As far as I know, CI does not run make lint

[afbjorklund]

I don't think you need to change anything for CI, I will just add another local target for when you don't want it.

Similar to make native when you don't want to build all weird architectures (and there is no way to configure anymore)

Or make exe when you just want to build and not want to clean, there could be a target to just run the lint commands.

I was trying with pre-commit, but that mostly made it worse - and not all the lint tools have python versions...

[suhas-developer07]

Thanks for the clarification — that makes sense

I misunderstood how CI invokes linting and assumed make lint was part of the CI flow. Thanks for pointing out that it isn’t.

I agree that CI behavior shouldn’t change. Adding a separate local-only target for running the lint commands without check-generated sounds like the right approach.

I can update the PR to introduce a local convenience target (e.g. lint-local) that just runs the lint commands, while keeping make lint unchanged. Let me know if that works for you.

[AkihiroSuda]

The code clone has to be eliminated

[AkihiroSuda]

Why not just decouple make lint from make check-generated and call it a day?