Update VPA dependencies, including k8s to 1.35-rc.0#8902
Update VPA dependencies, including k8s to 1.35-rc.0#8902adrianmoisey wants to merge 7 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/vertical-pod-autoscaler
size/XXL
|
(I'm not sure if we actually want to merge this, I just want to see what it looks like and if tests pass) |
omerap12
left a comment
omerap12
left a comment
There was a problem hiding this comment.
IMO, updating dependencies to an rc version isn’t ideal. We should wait for the full 1.35 release and update the dependencies afterward if needed.
Yeah, I figured I'd make something now, see what fails, and make smaller PRs to get ready (like remove use of deprecated functions) |
adrianmoisey
force-pushed
the
kubernetes-1.35
branch
from
35a45c9 to
6417c35
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | ||
| github.com/mxk/go-flowrate v0.0.0-20140419014527-cca7078d478f // indirect | ||
| github.com/opencontainers/cgroups v0.0.4 // indirect | ||
| github.com/opencontainers/cgroups v0.0.5 // indirect |
There was a problem hiding this comment.
There was a problem hiding this comment.
It seems we can't upgrade to 0.0.6 or higher until the above PR is merged and we depend on that version of kubernetes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
kind/api-change
adrianmoisey
force-pushed
the
kubernetes-1.35
branch
from
410bba5 to
d91d9c9
Compare
adrianmoisey
force-pushed
the
kubernetes-1.35
branch
2 times, most recently
from
dadf8f0 to
8e953f2
Compare
adrianmoisey
force-pushed
the
kubernetes-1.35
branch
from
8e953f2 to
4bc9596
Compare
|
/close |
|
@adrianmoisey: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In preparation of 1.35 being released
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: