Vibe coded some things I don't understand

Author: adrianmoisey

vertical-pod-autoscaler/go.mod

@@ -19,6 +19,7 @@ require (
 	k8s.io/code-generator v0.35.0-rc.0
 	k8s.io/component-base v0.35.0-rc.0
 	k8s.io/klog/v2 v2.130.1
+	k8s.io/kube-openapi v0.0.0-20251125145642-4e65d59e963e
 	k8s.io/metrics v0.35.0-rc.0
 	k8s.io/utils v0.0.0-20251002143259-bc988d571ff4
 	sigs.k8s.io/structured-merge-diff/v6 v6.3.1
@@ -77,7 +78,6 @@ require (
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 	k8s.io/gengo/v2 v2.0.0-20250922181213-ec3ebc5fd46b // indirect
-	k8s.io/kube-openapi v0.0.0-20251125145642-4e65d59e963e // indirect
 	sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect
 	sigs.k8s.io/randfill v1.0.0 // indirect
 	sigs.k8s.io/yaml v1.6.0 // indirect

vertical-pod-autoscaler/hack/update-codegen.sh

@@ -29,21 +29,54 @@ REPO_ROOT="$(git rev-parse --show-toplevel)"
 # shellcheck source=/dev/null
 source "${CODEGEN_PKG}/kube_codegen.sh"
 
+# Ensure openapi-gen is installed
+OPENAPI_PKG=$($GO_CMD list -m -mod=readonly -f "{{.Dir}}" k8s.io/kube-openapi)
+$GO_CMD install "${OPENAPI_PKG}/cmd/openapi-gen"
+
 kube::codegen::gen_helpers \
     "$(dirname ${BASH_SOURCE})/../pkg/apis" \
     --boilerplate "${REPO_ROOT}/hack/boilerplate/boilerplate.generatego.txt"
 
-echo "Ran gen helpers, moving on to generating client code..."
+echo "Ran gen helpers, moving on to generating openapi definitions..."
+
+# Generate OpenAPI definitions
+OPENAPI_OUTPUT_DIR="$(dirname ${BASH_SOURCE})/../pkg/generated/openapi"
+mkdir -p "${OPENAPI_OUTPUT_DIR}"
+
+openapi-gen \
+    --go-header-file "${REPO_ROOT}/hack/boilerplate/boilerplate.generatego.txt" \
+    --output-dir "${OPENAPI_OUTPUT_DIR}" \
+    --output-pkg "k8s.io/autoscaler/vertical-pod-autoscaler/pkg/generated/openapi" \
+    --output-file "zz_generated.openapi.go" \
+    --report-filename "${OPENAPI_OUTPUT_DIR}/violation_exceptions.list" \
+    "k8s.io/autoscaler/vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1" \
+    "k8s.io/autoscaler/vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1beta1" \
+    "k8s.io/autoscaler/vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1beta2" \
+    "k8s.io/autoscaler/vertical-pod-autoscaler/pkg/apis/poc.autoscaling.k8s.io/v1alpha1" \
+    "k8s.io/api/core/v1" \
+    "k8s.io/api/autoscaling/v1" \
+    "k8s.io/apimachinery/pkg/api/resource" \
+    "k8s.io/apimachinery/pkg/apis/meta/v1" \
+    "k8s.io/apimachinery/pkg/runtime" \
+    "k8s.io/apimachinery/pkg/version"
+
+echo "Generated openapi definitions, moving on to generating client code..."
+
+# Generate OpenAPI schema JSON for applyconfiguration-gen
+OPENAPI_SCHEMA_FILE=$(mktemp)
+trap "rm -f ${OPENAPI_SCHEMA_FILE}" EXIT
+$GO_CMD run "$(dirname ${BASH_SOURCE})/../pkg/generated/openapi/cmd/models-schema" > "${OPENAPI_SCHEMA_FILE}"
 
 kube::codegen::gen_client \
   "$(dirname ${BASH_SOURCE})/../pkg/apis" \
   --output-pkg k8s.io/autoscaler/vertical-pod-autoscaler/pkg/client \
   --output-dir "$(dirname ${BASH_SOURCE})/../pkg/client" \
   --boilerplate "${REPO_ROOT}/hack/boilerplate/boilerplate.generatego.txt" \
   --with-watch \
-  --with-applyconfig
+  --with-applyconfig \
+  --applyconfig-openapi-schema "${OPENAPI_SCHEMA_FILE}"
 
-echo "Generated client code, running `go mod tidy`..."
+echo "Generated client code, running \`go mod tidy\`..."
 
 # We need to clean up the go.mod file since code-generator adds temporary library to the go.mod file.
 "${GO_CMD}" mod tidy

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/doc.go

@@ -17,6 +17,7 @@ limitations under the License.
 // +k8s:deepcopy-gen=package,register
 
 // Package v1 contains definitions of Vertical Pod Autoscaler related objects.
+// +k8s:openapi-gen=true
 // +groupName=autoscaling.k8s.io
 // +kubebuilder:object:generate=true
 package v1

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

@@ -438,6 +438,7 @@ type HistogramCheckpoint struct {
 	// Map from bucket index to bucket weight.
 	// +kubebuilder:validation:Type=object
 	// +kubebuilder:validation:XPreserveUnknownFields
+	// +k8s:openapi-gen=false
 	BucketWeights map[int]uint32 `json:"bucketWeights,omitempty" protobuf:"bytes,2,opt,name=bucketWeights"`
 
 	// Sum of samples to be used as denominator for weights from BucketWeights.

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1beta1/doc.go

@@ -17,6 +17,7 @@ limitations under the License.
 // +k8s:deepcopy-gen=package,register
 
 // Package v1beta1 contains definitions of Vertical Pod Autoscaler related objects.
+// +k8s:openapi-gen=true
 // +groupName=autoscaling.k8s.io
 // +kubebuilder:skip
 package v1beta1

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1beta1/types.go

@@ -315,6 +315,7 @@ type HistogramCheckpoint struct {
 	ReferenceTimestamp metav1.Time `json:"referenceTimestamp,omitempty" protobuf:"bytes,1,opt,name=referenceTimestamp"`
 
 	// Map from bucket index to bucket weight.
+	// +k8s:openapi-gen=false
 	BucketWeights map[int]uint32 `json:"bucketWeights,omitempty" protobuf:"bytes,2,opt,name=bucketWeights"`
 
 	// Sum of samples to be used as denominator for weights from BucketWeights.

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1beta2/doc.go

@@ -17,6 +17,7 @@ limitations under the License.
 // +k8s:deepcopy-gen=package,register
 
 // Package v1beta2 contains definitions of Vertical Pod Autoscaler related objects.
+// +k8s:openapi-gen=true
 // +groupName=autoscaling.k8s.io
 // +kubebuilder:object:generate=true
 package v1beta2

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1beta2/types.go

@@ -348,6 +348,7 @@ type HistogramCheckpoint struct {
 	// Map from bucket index to bucket weight.
 	// +kubebuilder:validation:Type=object
 	// +kubebuilder:validation:XPreserveUnknownFields
+	// +k8s:openapi-gen=false
 	BucketWeights map[int]uint32 `json:"bucketWeights,omitempty" protobuf:"bytes,2,opt,name=bucketWeights"`
 
 	// Sum of samples to be used as denominator for weights from BucketWeights.

vertical-pod-autoscaler/pkg/apis/poc.autoscaling.k8s.io/v1alpha1/doc.go

@@ -17,6 +17,7 @@ limitations under the License.
 // +k8s:deepcopy-gen=package,register
 
 // Package v1alpha1 contains definitions of Vertical Pod Autoscaler related objects.
+// +k8s:openapi-gen=true
 // +groupName=poc.autoscaling.k8s.io
 // +kubebuilder:skip
 package v1alpha1

vertical-pod-autoscaler/pkg/apis/poc.autoscaling.k8s.io/v1alpha1/types.go

@@ -306,6 +306,7 @@ type HistogramCheckpoint struct {
 	ReferenceTimestamp metav1.Time `json:"referenceTimestamp,omitempty" protobuf:"bytes,1,opt,name=referenceTimestamp"`
 
 	// Map from bucket index to bucket weight.
+	// +k8s:openapi-gen=false
 	BucketWeights map[int]uint32 `json:"bucketWeights,omitempty" protobuf:"bytes,2,opt,name=bucketWeights"`
 
 	// Sum of samples to be used as denominator for weights from BucketWeights.