Skip to content

refactor: upgrade notebooks v1 frontends to Angular 16 #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alokdangre wants to merge 10 commits into
base: notebooks-v1
Choose a base branch
from
Open

refactor: upgrade notebooks v1 frontends to Angular 16 #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b2f93b9
fix: upgrade notebooks v1 frontends to Angular 16
alokdangre Mar 25, 2026
7c0413c
fix: repair angular 16 frontend test bootstrap
alokdangre Mar 25, 2026
6931dfc
fix: address remaining angular 16 frontend CI failures
alokdangre Mar 25, 2026
eaabb1e
fix: address remaining angular 16 test regressions
alokdangre Mar 25, 2026
575ae51
fix: stabilize remaining angular 16 frontend tests
alokdangre Mar 25, 2026
a22a257
fix: repair remaining angular 16 ui and build ci
alokdangre Mar 25, 2026
6e68d3a
fix: restore partial compilation for kubeflow lib
alokdangre Mar 25, 2026
a48eac0
fix: avoid kubeflow imports in e2e specs
alokdangre Mar 25, 2026
34fd169
fix: finalize angular 16 tab spec assertions
alokdangre Mar 25, 2026
f030ac3
fix: complete angular 16 dev bootstrap configuration
alokdangre Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 7 additions & 22 deletions components/crud-web-apps/common/frontend/kubeflow-common-lib/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,15 @@
{
"root": true,
"ignorePatterns": [
"projects/**/*"
],
"ignorePatterns": ["projects/**/*"],
"overrides": [
{
"files": [
"*.ts"
],
"files": ["*.ts"],
"parserOptions": {
"project": [
"tsconfig.json",
"e2e/tsconfig.json"
],
"project": ["tsconfig.json"],
"createDefaultProgram": true
},
"extends": [
"plugin:@angular-eslint/ng-cli-compat",
"plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
"plugin:@angular-eslint/recommended",
"plugin:@angular-eslint/template/process-inline-templates"
],
"rules": {
Expand All @@ -31,20 +23,13 @@
"@typescript-eslint/member-ordering": "off",
"@angular-eslint/no-input-rename": "off",
"prefer-arrow/prefer-arrow-functions": "off",
"arrow-parens": [
"off",
"always"
],
"arrow-parens": ["off", "always"],
"import/order": "off"
}
},
{
"files": [
"*.html"
],
"extends": [
"plugin:@angular-eslint/template/recommended"
],
"files": ["*.html"],
"extends": ["plugin:@angular-eslint/template/recommended"],
"rules": {}
}
]
Expand Down
7 changes: 2 additions & 5 deletions components/crud-web-apps/common/frontend/kubeflow-common-lib/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"$schema": "./node_modules/@angular/cli/lib/config/schema.json",
"cli": {
"analytics": false
"analytics": false,
"schematicCollections": ["@angular-eslint/schematics"]
},
"version": 1,
"newProjectRoot": "projects",
Expand Down Expand Up @@ -43,9 +44,5 @@
}
}
}
},
"defaultProject": "kubeflow",
"cli": {
"defaultCollection": "@angular-eslint/schematics"
}
}
Loading
Loading