refactor: upgrade notebooks v1 frontends to Angular 16#990
Open
alokdangre wants to merge 10 commits intokubeflow:notebooks-v1from
Open
refactor: upgrade notebooks v1 frontends to Angular 16#990alokdangre wants to merge 10 commits intokubeflow:notebooks-v1from
alokdangre wants to merge 10 commits intokubeflow:notebooks-v1from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
added
area/frontend
alokdangre
force-pushed
the
fix/notebooks-v1-angular16
branch
from
f8b9991 to
f030ac3
Compare
Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: alokdangre <alokdangre@gmail.com>
Signed-off-by: alokdangre <alokdangre@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the Kubeflow notebooks v1 frontend stack to Angular 16 and keeps the shared kubeflow-common-lib aligned with the JWA, TWA, and VWA apps. The migration preserves existing behavior while moving the build, test, and Material layers onto the Angular 16 and Ivy toolchain.
Changes
Upgraded Angular, Angular Material/CDK, RxJS, Zone.js, and TypeScript across common-lib, JWA, TWA, and VWA.
Migrated shared Material templates and styles to Angular 16 compatible APIs.
Updated library and workspace configuration for Ivy and partial compilation, and removed obsolete Angular 14-era compiler settings.
Added dev-only bootstrap/config for the browser test runners so Angular 16 dev-server based UI tests work reliably.
Updated unit and e2e specs to match MDC rendered output and the newer routing/test behavior.
Regenerated the package lockfiles and formatted the touched files.