fix: prevent duplicate volumes when same PVC is mounted to multiple paths#1023
Open
Jaehyeon1020 wants to merge 1 commit intokubeflow:notebooks-v1from
Open
fix: prevent duplicate volumes when same PVC is mounted to multiple paths#1023Jaehyeon1020 wants to merge 1 commit intokubeflow:notebooks-v1from
Jaehyeon1020 wants to merge 1 commit intokubeflow:notebooks-v1from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
bot
added
area/frontend
Jaehyeon1020
force-pushed
the
fix/duplicate-notebook-volumes
branch
from
8e010cd to
cf3ab22
Compare
…aths When the same PVC is configured with multiple mount paths in the web UI, the volume creation loop calls add_notebook_volume for each mount, adding a V1Volume with the same name multiple times. This causes a Kubernetes validation error due to duplicate volume names in the PodSpec. Track already-added volume names in the loop to skip duplicates while still adding all volume mounts. Signed-off-by: Jaehyeon1020 <[email protected]>
Jaehyeon1020
force-pushed
the
fix/duplicate-notebook-volumes
branch
from
decc5e8 to
f64b579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the same PVC is mounted to multiple paths via the Jupyter Web App UI,
add_notebook_volumeappends aV1Volumewith the same name for each mount. This causes a Kubernetes validation error (duplicate volume names inspec.volumes) and the Pod fails to start.Fix: Track already-added volume names in the volume creation loop (
post.py) to skip duplicateadd_notebook_volumecalls.add_notebook_container_mountis unchanged since multiplevolumeMountsreferencing the same volume is valid in Kubernetes.How to test:
/dataand/backup)