fix: prevent duplicate volumes when same PVC is mounted to multiple paths

When the same PVC is configured with multiple mount paths in the web UI,
the volume creation loop calls add_notebook_volume for each mount, adding
a V1Volume with the same name multiple times. This causes a Kubernetes
validation error due to duplicate volume names in the PodSpec.

Track already-added volume names in the loop to skip duplicates while
still adding all volume mounts.

Signed-off-by: Jaehyeon1020 <[email protected]>

Author: Jaehyeon1020

components/crud-web-apps/jupyter/backend/apps/common/volumes_test.py

@@ -111,3 +111,31 @@ def test_use_pvc_name_in_volume_source(self):
                 "claimName": PVC_NAME,
             },
         })
+
+
+class TestAddNotebookVolume(unittest.TestCase):
+    """Test the functionality of the add_notebook_volume function."""
+
+    def setUp(self):
+        """Create a minimal Notebook CR dict."""
+        self.notebook = {
+            "spec": {
+                "template": {
+                    "spec": {
+                        "containers": [{"volumeMounts": []}],
+                    },
+                },
+            },
+        }
+        self.volume = {
+            "name": PVC_NAME,
+            "persistentVolumeClaim": {"claimName": PVC_NAME},
+        }
+
+    def test_add_volume(self):
+        """Add a volume to the Notebook's PodSpec."""
+        volumes.add_notebook_volume(self.notebook, self.volume)
+        podspec = self.notebook["spec"]["template"]["spec"]
+        self.assertEqual(len(podspec["volumes"]), 1)
+        self.assertEqual(podspec["volumes"][0]["name"], PVC_NAME)
+

components/crud-web-apps/jupyter/backend/apps/default/routes/post.py

@@ -57,6 +57,7 @@ def post_pvc(namespace):
         api.create_pvc(pvc, namespace, dry_run=True)
 
     # create the new PVCs and set the Notebook volumes and mounts
+    added_volumes = set()
     for api_volume in api_volumes:
         pvc = volumes.get_new_pvc(api_volume)
         if pvc is not None:
@@ -66,7 +67,10 @@ def post_pvc(namespace):
         v1_volume = volumes.get_pod_volume(api_volume, pvc)
         mount = volumes.get_container_mount(api_volume, v1_volume["name"])
 
-        notebook = volumes.add_notebook_volume(notebook, v1_volume)
+        if v1_volume["name"] not in added_volumes:
+            notebook = volumes.add_notebook_volume(notebook, v1_volume)
+            added_volumes.add(v1_volume["name"])
+
         notebook = volumes.add_notebook_container_mount(notebook, mount)
 
     log.info("Creating Notebook: %s", notebook)