Skip to content

chore: drop the namespaces to resolve kustomize conflicts#1005

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:notebooks-v2from
christian-heusel:chore/drop-namespace
Apr 2, 2026
Merged

chore: drop the namespaces to resolve kustomize conflicts#1005
google-oss-prow[bot] merged 1 commit intokubeflow:notebooks-v2from
christian-heusel:chore/drop-namespace

Conversation

@christian-heusel
Copy link
Copy Markdown
Contributor

@christian-heusel christian-heusel commented Apr 1, 2026

Link: kubeflow/manifests#3430 (comment)

Todo:

  • check if this breaks any tests

Link: kubeflow/manifests#3430 (comment)
Signed-off-by: Christian Heusel <christian@heusel.eu>
@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Apr 1, 2026
@google-oss-prow google-oss-prow bot requested review from andyatmiami and ederign April 1, 2026 17:18
@google-oss-prow google-oss-prow bot added area/backend area - related to backend components area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 labels Apr 1, 2026
@christian-heusel
Copy link
Copy Markdown
Contributor Author

/ok-to-test

Copy link
Copy Markdown
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Based on the comment by @thesuperzapper here:

I can confirm this PR accomplishes its stated goal.

I ran the app via tilt and confirmed (unsurprisingly) that everything still works locally with these namespace resources being removed.

This should also help me when I (eventually) finish documenting deployment instructions here:

As I imagine this same issue was going to fail the (very outdated) instructions as written 💯

@ederign
Copy link
Copy Markdown
Member

ederign commented Apr 2, 2026

/approve
/lgtm

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyatmiami, ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e31f011 into kubeflow:notebooks-v2 Apr 2, 2026
21 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Apr 2, 2026
thesuperzapper pushed a commit that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/backend area - related to backend components area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/S

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants