synchronize kubeflow workspaces manifests v2.0.0 alpha.1#3430
synchronize kubeflow workspaces manifests v2.0.0 alpha.1#3430christian-heusel wants to merge 6 commits intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR introduces the initial synchronization of experimental Kubernetes Notebook v2 manifests from the upstream kubeflow/notebooks repository at version v2.0.0-alpha.0. The PR includes a synchronization script, comprehensive controller/backend/frontend manifests with Istio integration, sample configurations, and a patch to add a notebooks-v2 entry to the central dashboard sidebar (currently commented out with a pre-GA warning).
Changes:
- Created a synchronization script (
scripts/synchronize-notebooks-v2-manifests.sh) to automate future manifest updates - Added complete experimental notebooks-v2 manifests (backend, frontend, controller) with Istio networking integration
- Included sample WorkspaceKind and Workspace resources demonstrating usage
- Added centraldashboard configuration patch to expose notebooks-v2 in the UI
- Updated example kustomization to document notebooks-v2 availability (with pre-GA warnings and commented out)
Reviewed changes
Copilot reviewed 76 out of 77 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
scripts/synchronize-notebooks-v2-manifests.sh |
Script to automate synchronization of upstream notebooks-v2 manifests |
experimental/notebooks-v2/kustomization.yaml |
Root kustomization composing backend, controller, and frontend with image tag fixes |
experimental/notebooks-v2/backend/ |
Backend service manifests with Istio overlay and RBAC configuration |
experimental/notebooks-v2/controller/ |
Workspaces controller with CRDs, webhooks, and cert-manager integration |
experimental/notebooks-v2/frontend/ |
Frontend UI deployment with Istio ingress routing |
experimental/notebooks-v2/centraldashboard/ |
ConfigMap patch adding notebooks-v2 menu items to central dashboard |
example/kustomization.yaml |
Documentation comments for optional notebooks-v2 deployment |
16265d1 to
fd04a9f
Compare
|
@christian-heusel I think the best structure is to keep everything under Structure should be: applications:
- workspaces:
- upstream:
- controller:
- base, overlays, components, etc
- backend:
- base, overlays, components, etc
- frontend:
- base, overlays, components, etc
- overlays:
- istio:
- xyz_patch.yaml (if needed can be included).
- kustomization.yaml (points to the `overlays/istio` of each upstream)Then we have a single sync target under |
cab81d8 to
e32edf7
Compare
|
/hold |
Link: kubeflow#3430 (comment) Link: kubeflow#3429 (comment) Signed-off-by: Christian Heusel <[email protected]>
e32edf7 to
d3d678c
Compare
Link: kubeflow/manifests#3430 (comment) Signed-off-by: Christian Heusel <[email protected]>
Link: kubeflow#3430 (comment) Link: kubeflow#3429 (comment) Signed-off-by: Christian Heusel <[email protected]>
Link: kubeflow/manifests#3430 (comment) Signed-off-by: Christian Heusel <[email protected]>
Without this we're running into `ImagePullBackOff` issues in the release manifests and need to manually fix the tags there. Link: kubeflow/manifests#3430 (comment) Signed-off-by: Christian Heusel <[email protected]>
Without this we're running into `ImagePullBackOff` issues in the release manifests and need to manually fix the tags there. Link: kubeflow/manifests#3430 (comment) Signed-off-by: Christian Heusel <[email protected]>
Without this we're running into `ImagePullBackOff` issues in the release manifests and need to manually fix the tags there. Link: kubeflow/manifests#3430 (comment) Signed-off-by: Christian Heusel <[email protected]>
Link: kubeflow/manifests#3430 (comment) Signed-off-by: Christian Heusel <[email protected]>
Without this we're running into `ImagePullBackOff` issues in the release manifests and need to manually fix the tags there. Link: kubeflow/manifests#3430 (comment) Signed-off-by: Christian Heusel <[email protected]>
d3d678c to
9afe2a9
Compare
9afe2a9 to
72c8d1e
Compare
Link: kubeflow#3430 (comment) Link: kubeflow#3429 (comment) Signed-off-by: Christian Heusel <[email protected]>
72c8d1e to
e1ac53a
Compare
Link: kubeflow#3430 (comment) Link: kubeflow#3429 (comment) Signed-off-by: Christian Heusel <[email protected]>
* Update kubeflow/notebooks manifests from v1.11.0-rc.1 Signed-off-by: Christian Heusel <[email protected]> * Restructure the notebooks-v1 component manifests Link: #3430 (comment) Link: #3429 (comment) Signed-off-by: Christian Heusel <[email protected]> --------- Signed-off-by: Christian Heusel <[email protected]>
|
if you want you can also kill the notebooks v1 helm charts in this PR. Since we will kill v1 there is no potential to upstream them in the future. |
Signed-off-by: Christian Heusel <[email protected]>
Signed-off-by: Christian Heusel <[email protected]>
Signed-off-by: Christian Heusel <[email protected]>
Adds a GitHub Actions workflow that deploys all three Workspaces components (controller, backend, frontend) and verifies the access permissions to the backend API through the Istio ingress gateway. Assisted-By: Claude Sonnet 4.6 <[email protected]> Signed-off-by: Christian Heusel <[email protected]>
Link: kubeflow#3430 (comment) Suggested-by: Julius von Kohout <[email protected]> Signed-off-by: Christian Heusel <[email protected]>
e1ac53a to
d08b4fa
Compare
Link: kubeflow#3430 (comment) Suggested-by: Julius von Kohout <[email protected]> Signed-off-by: Christian Heusel <[email protected]>
d08b4fa to
11ec53b
Compare
Link: kubeflow#3430 (comment) Suggested-by: Julius von Kohout <[email protected]> Signed-off-by: Christian Heusel <[email protected]>
Adds a second integration test that spawns a Workspace and runs a pipeline inside it, mirroring `pipeline_run_from_notebook.yaml` for the Notebooks Workspaces. Assisted-By: Claude Sonnet 4.6 <[email protected]> Signed-off-by: Christian Heusel <[email protected]>
11ec53b to
79ea0ae
Compare
|
/retest |
|
@christian-heusel failures here are a combination of the prerelease image-tag mismatch (v2.0.0-alpha.1 in manifests https://github.com/kubeflow/manifests/pull/3430/changes#diff-2145495ad76e99d7bebb590b3ab3c4fb6dec9b87f0092b3ff4c7adf9cd36311dR20 vs 2.0.0-alpha.1 in GHCR) plus stale workflow assumptions in the new tests global all-namespaces pod wait that times out on unrelated KinD dependencies https://github.com/kubeflow/manifests/pull/3430/changes#diff-8b3cd760feec7fb87c30efb305a6f3031f13ede999a21dcf1aa2c7bc5a88e8acR51 should wait first for cert-manager pods and then for pods in the only in kubeflow-workspaces namespace controller test hitting the old /workspaces/api/v1/namespaces/{ns}/workspaces route https://github.com/kubeflow/manifests/pull/3430/changes#diff-8b3cd760feec7fb87c30efb305a6f3031f13ede999a21dcf1aa2c7bc5a88e8acR76 instead of /workspaces/api/v1/workspaces/{ns} pipeline test assuming the workspace pod is always named test-0 even though the controller now generates that name dynamically .https://github.com/kubeflow/manifests/pull/3430/changes#diff-0dbda89ab22f251a228374464802a7f6b04345db1a5292dcbbb8b264b876f255R84 i have fixed and validated the changes required ( see commits on my fork danish9039@d76d396 ) |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
Do the initial sync for the experimental notebooks v2 manifests.
📦 Dependencies
none
🐛 Related Issues
none
✅ Contributor Checklist
cc @andyatmiami @thesuperzapper