Skip to content

Huber pnp refine - #1111

Merged
cjpurackal merged 5 commits into
kornia:mainfrom
Astik-2002:huber-pnp-refine
Aug 19, 2026
Merged

Huber pnp refine#1111
cjpurackal merged 5 commits into
kornia:mainfrom
Astik-2002:huber-pnp-refine

Conversation

@Astik-2002

Copy link
Copy Markdown
Contributor

📝 Description

Fix for the issue [https://github.com//issues/1099]
⚠️ Issue Link Required: This PR must be linked to an approved and assigned issue. See Contributing Guide for details.

Added huber kernel in PnP pose refinement

🛠️ Changes Made

  • Added robust loss in refine.rs
  • Added testcases for testing huber loss

🧪 How Was This Tested?

  • [✓] Unit Tests: (List new/updated tests)
  • [✓] Manual Verification: (Describe the steps you took)
  • Performance/Edge Cases: (How does this handle nulls, large data, etc.?)

🕵️ AI Usage Disclosure

Check one of the following:

  • 🟢 No AI used.
  • [✓] 🟡 AI-assisted: I used AI for boilerplate/refactoring but have manually reviewed and tested every line.
  • 🔴 AI-generated: (Note: These PRs may be subject to stricter scrutiny or immediate closure if the logic is not explained).

🚦 Checklist

  • [✓] I am assigned to the linked issue (required before PR submission)
  • The linked issue has been approved by a maintainer
  • This PR strictly implements what the linked issue describes (no scope creep)
  • I have performed a self-review of my code (no "ghost" variables or hallucinations).
  • My code follows the existing style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • (Optional) I have attached screenshots/recordings for UI changes.

💭 Additional Context

Add any other context or screenshots about the pull request here.

@github-actions

Copy link
Copy Markdown

⚠️ PR Validation Warnings

No linked issue found: This PR does not reference any issue. Please link to an issue using "Fixes #123" or "Closes #123" in the PR description.


Note: This PR can remain open, but please address these issues to ensure a smooth review process. For more information, see our Contributing Guide.

@Astik-2002
Astik-2002 marked this pull request as ready for review August 19, 2026 02:16
@qodo-code-review

Copy link
Copy Markdown
Contributor

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@cjpurackal

Copy link
Copy Markdown
Member

I have some concerns with tuning the max iterations and tolerances but I'll merge for now and change later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants