Open
Conversation
|
This fixes #350 |
bleggett
approved these changes
Aug 15, 2025
bleggett
left a comment
bleggett
left a comment
There was a problem hiding this comment.
LGTM, also hit the same error and applied the same fix locally 👍
neuschaefer
reviewed
Sep 26, 2025
| self.flags.push(home.display().to_string()); // FIXME: we shouldn't use display, we should keep the OsString | ||
| // As per CARGO_ENCODED_RUSTFLAGS docs, the separator is `0x1f`. | ||
| // As per CARGO_ENCODED_RUSTFLAGS docs, the separator is `0x1f`. | ||
| self.flags.join("\x1f") |
There was a problem hiding this comment.
This formatting change looks semantically wrong. I think the first comment is about home.display()..., but the second one isn't a continuation of it, it's about self.flags.join("\x1f"). The way rustfmt will probably respect the old semantics is by having an empty line between them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the minimal necessary updates to get
xargocompiling with the latest Rust toolchain. No functional changes were made - just adjustments to ensure compatibility... also applied code formatting usingcargo fmt.