Add ability to set rust version explicitly, rather than rustup latest#1699
Closed
bleggett wants to merge 1 commit intocross-rs:mainfrom
edera-dev:bleggett/rust-version
Closed
Add ability to set rust version explicitly, rather than rustup latest#1699bleggett wants to merge 1 commit intocross-rs:mainfrom edera-dev:bleggett/rust-version
rustup latest#1699bleggett wants to merge 1 commit intocross-rs:mainfrom
edera-dev:bleggett/rust-version
Conversation
Member
|
Thank you for the pr! However, I think I'd rather just remove xargo, it's not needed anymore with build-std working well. What do you think? see #692 |
Author
Ah, missed that! That sounds better. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image build scripts always let the
rustupbinary choose the latestrusttarget version to install.This can break things when
rustupis updated and pulls a newer version of rust that the components in this repo haven't yet been updated to build against, see japaric/xargo#349 for example.That can be fixed, but in general it would be good to allow a specific/fixed/pinned version to be specified, if desired, for whatever reason.
This PR adds the ability to request a specific rust target version by setting the
RUST_VERSIONcontainer arg, such asRUST_VERSION=1.88if unset, or
RUST_VERSION=latest, fall back to current behavior of lettingrustupdecide what version to install (current behavior).I updated the
ARGdefault forRUST_VERSIONto belatestin all the images, for the sake of explicitness.