Skip to content

Add ability to set rust version explicitly, rather than rustup latest#1699

Closed
bleggett wants to merge 1 commit intocross-rs:mainfrom
edera-dev:bleggett/rust-version
Closed

Add ability to set rust version explicitly, rather than rustup latest#1699
bleggett wants to merge 1 commit intocross-rs:mainfrom
edera-dev:bleggett/rust-version

Conversation

@bleggett
Copy link
Copy Markdown

The image build scripts always let the rustup binary choose the latest rust target version to install.

This can break things when rustup is updated and pulls a newer version of rust that the components in this repo haven't yet been updated to build against, see japaric/xargo#349 for example.

That can be fixed, but in general it would be good to allow a specific/fixed/pinned version to be specified, if desired, for whatever reason.

This PR adds the ability to request a specific rust target version by setting the RUST_VERSION container arg, such as

  • RUST_VERSION=1.88

if unset, or RUST_VERSION=latest, fall back to current behavior of letting rustup decide what version to install (current behavior).

I updated the ARG default for RUST_VERSION to be latest in all the images, for the sake of explicitness.

@bleggett bleggett requested a review from a team as a code owner August 15, 2025 18:01
@Emilgardis
Copy link
Copy Markdown
Member

Emilgardis commented Aug 15, 2025

Thank you for the pr! However, I think I'd rather just remove xargo, it's not needed anymore with build-std working well. What do you think? see #692

@bleggett
Copy link
Copy Markdown
Author

Thank you for the pr! However, I think I'd rather just remove xargo, it's not needed anymore with build-std working well. What do you think? see #692

Ah, missed that! That sounds better.

@bleggett bleggett closed this Aug 18, 2025
@Emilgardis Emilgardis mentioned this pull request Aug 28, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants