-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Support per-side rod borders used for bar chart #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
haashem
wants to merge
13
commits into
imaNNeo:main
Choose a base branch
from
haashem:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
03ac438
feat: bar charts can have customized border sides
haashem 51fe6d9
feat: update sample to include top border
haashem b799343
test: uses butt stroke cap for dashed per-side border
haashem 76f022a
refactor: move normalizeBorder to the utils class for reusability
haashem d5565c8
refactor: deprecate `borderSide`
haashem 2d5984b
refactor: get dashArray once
haashem 1354790
refactor: simplify per side border drawing
haashem b0df650
Merge branch 'main' into main
haashem 6bb8db0
test: ignore deprecated_member_use_from_same_package
haashem fcf5fe2
test: renders clip rect for each border side when border is provided
haashem c813c1c
refactor: create reusable test setup for bar creation
haashem 9550ad0
fix: matching original stroke semantics
haashem 320cda6
fix: draw nonuniform borders inside the stroke line
haashem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.