feat: Support per-side rod borders used for bar chart#2088
Open
haashem wants to merge 13 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
==========================================
+ Coverage 93.07% 94.27% +1.19%
==========================================
Files 50 54 +4
Lines 3956 4785 +829
==========================================
+ Hits 3682 4511 +829
Misses 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
imaNNeo
requested changes
Apr 20, 2026
Owner
Contributor
Author
Contributor
Author
|
@imaNNeo May I have your review again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
add support for per-side borders on
BarChartRodDataso users can render borders like top-only, left-only, etc.Bar border are rendered inside - outside/centers makes bars look taller/shorter than data and can collide with nearby bars.
Resolves #1194
API
Border? bordertoBarChartRodData.borderSidefor backward compatibility.borderis provided, it is used.borderSidebehavior is preserved.Painter updates
borderSide)border)Checklist
///.example.Breaking Change?
Related Issues
Closes #1194