Minor PID controller improvement: use cache millis instead of calling…#11439
Open
DzikuVx wants to merge 1 commit intomaintenance-10.xfrom
Open
Minor PID controller improvement: use cache millis instead of calling…#11439DzikuVx wants to merge 1 commit intomaintenance-10.xfrom
DzikuVx wants to merge 1 commit intomaintenance-10.xfrom
Conversation
… millis() multiple times in the loop.
|
Test firmware build ready — commit Download firmware for PR #11439 225 targets built. Find your board's
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR caches the result of millis() at the start of the PID controller loop into a static variable pidLoopNowMs, replacing multiple millis() calls within the loop with reads of that cached value. This ensures time consistency within a single PID loop iteration and avoids redundant system calls.
Changes:
- Added a new
static EXTENDED_FASTRAMvariablepidLoopNowMsto cache the current time at the start of each PID loop iteration. - Replaced two
millis()calls iniTermLockApply()with reads from the cachedpidLoopNowMs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… millis() multiple times in the loop.