Add include and exclude devices to device selector#165599
Open
andrew-codechimp wants to merge 2 commits intohome-assistant:devfrom
Open
Add include and exclude devices to device selector#165599andrew-codechimp wants to merge 2 commits intohome-assistant:devfrom
andrew-codechimp wants to merge 2 commits intohome-assistant:devfrom
Conversation
This was referenced Mar 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional include_devices / exclude_devices filtering support to the backend device selector, enabling callers (e.g., future “helper-style” flows) to constrain which device IDs are valid selections.
Changes:
- Extend
DeviceSelectorconfig schema/types to acceptinclude_devicesandexclude_devices. - Enforce include/exclude validation when a device selector value is submitted (single and multiple modes).
- Add unit tests covering include/exclude behavior for device selectors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/helpers/selector.py |
Adds include/exclude lists to device selector config and validates selections against them. |
tests/helpers/test_selector.py |
Adds test cases verifying include/exclude validation for single and multi device selection. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add optional include and exclude device id lists to the device selector.
This will be useful for future helper style integrations where it is not applicable to add a second helper to a device.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: