Skip to content

Remove pimu.push_command() out of event loop#107

Open
hello-chintan wants to merge 1 commit intonoeticfrom
bugfix/pimu_push_command
Open

Remove pimu.push_command() out of event loop#107
hello-chintan wants to merge 1 commit intonoeticfrom
bugfix/pimu_push_command

Conversation

@hello-chintan
Copy link
Copy Markdown
Contributor

Is there a reason for constantly sending a pimu.push_command() in the main event loop of stretch_driver? If it is just for turning the fan on at startup, could it be handled once outside the loop?

Doing so breaks the runstop service as the runstop trigger and reset methods are not followed by a push command. Have added the fix to this PR.

@hello-fazil
Copy link
Copy Markdown
Contributor

hello-fazil commented Jul 12, 2023

@hello-chintan
We have seen the Pimu fan turn off by itself a few seconds after turning on the fan with a push command. Therefore as a patch, we push the command to turn on the fan every loop to keep the fan always running. But this should be a harmless push, as trigger syncs are not involved.

@hello-chintan
Copy link
Copy Markdown
Contributor Author

@hello-fazil Gotcha! Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants