Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s build/runtime base images and Go/Kubernetes dependencies, along with GolangCI-Lint configuration adjustments.
Changes:
- Bumped SUSE BCI base images and Go toolchain image tags.
- Updated Go module dependencies (notably Kubernetes + related libs) and switched to stdlib
slices. - Refreshed GolangCI-Lint configuration and added targeted
gosecsuppression in tests.
Reviewed changes
Copilot reviewed 9 out of 1814 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/test_1_disk_hotplug_test.go | Normalizes ssh-config path handling and adds gosec nolint annotation for exec helper. |
| tests/integration/test_0_single_disk_test.go | Normalizes ssh-config path handling. |
| pkg/controller/blockdevice/scanner.go | Switches from k8s.io/utils/strings/slices to stdlib slices. |
| pkg/block/block_device.go | Cleans the udev data file path before reading. |
| package/Dockerfile.webhook | Bumps BCI base image version. |
| package/Dockerfile | Bumps BCI base image version and adjusts installed util-linux packages. |
| go.mod | Bumps Go version and updates Kubernetes/related Go dependencies. |
| Dockerfile.dapper | Bumps Go toolchain image tag. |
| .golangci.yaml | Updates GolangCI-Lint v2 config schema and moves gofmt formatter config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var stdout bytes.Buffer | ||
| var stderr bytes.Buffer | ||
| cmd := exec.Command("bash", "-c", cmdString) | ||
| cmd := exec.Command("bash", "-c", cmdString) //nolint:gosec // G702: intentional test helper for running shell commands |
There was a problem hiding this comment.
The inline justification cites G702, which is not the gosec rule typically emitted for exec.Command (usually G204). Since this comment is used for auditability, please update the referenced rule/code or reword it to describe the actual finding being suppressed (or drop the rule number if you want it to be future-proof).
| cmd := exec.Command("bash", "-c", cmdString) //nolint:gosec // G702: intentional test helper for running shell commands | |
| cmd := exec.Command("bash", "-c", cmdString) //nolint:gosec // intentional test helper for running shell commands |
| FROM registry.suse.com/bci/bci-base:15.7 | ||
| FROM registry.suse.com/bci/bci-base:16.0 | ||
|
|
||
| # util-linux-systemd -> for `lsblk` command |
There was a problem hiding this comment.
The comment says util-linux-systemd is needed for lsblk, but the Dockerfile now also installs util-linux explicitly. Please update the comment to reflect the current package requirements (e.g., lsblk coming from util-linux) so it stays accurate.
| # util-linux-systemd -> for `lsblk` command | |
| # util-linux -> for `lsblk` command |
| # iproute2 -> for `ip` command | ||
| RUN zypper -n rm container-suseconnect && \ | ||
| zypper -n install util-linux-systemd e2fsprogs iproute2 && \ | ||
| zypper -n install util-linux util-linux-systemd e2fsprogs iproute2 && \ |
There was a problem hiding this comment.
The comment says util-linux-systemd is needed for lsblk, but the Dockerfile now also installs util-linux explicitly. Please update the comment to reflect the current package requirements (e.g., lsblk coming from util-linux) so it stays accurate.
- golang 1.25.7
- k8s 1.35.0
- Longhorn v1.11.0
- wrangler v3.4.0
- bci 16.0 (added util-linux)
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
bump-golang-k8s-bci
branch
from
81e41a8 to
d93081d
Compare
- align with harvester/harvester repo
- fix linter warning
- update vendor/generated code
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
bump-golang-k8s-bci
branch
from
d93081d to
852a35c
Compare
|
Please ignore the codefactor warning, we don't need to give the specific version for system tools. |
Problem:
Bump golang/k8s/bci, also update linter
Solution:
Bump golang/k8s/bci, also update linter
Related Issue:
harvester/harvester#10110
Test plan:
CI should pass