common: update linter

    - align with harvester/harvester repo
    - fix linter warning
    - update vendor/generated code

Signed-off-by: Vicente Cheng <[email protected]>

Author: Vicente-Cheng

.golangci.yaml

@@ -1,6 +1,6 @@
-version: 2
+version: "2"
 linters:
-  disable-all: true
+  default: none
   enable:
     - errcheck
     - govet
@@ -10,9 +10,6 @@ linters:
     - unused
     - misspell
     - prealloc
-  formatters:
-    enable:
-      - gofmt
   settings:
     gosec:
       # https://github.com/securego/gosec#available-rules
@@ -24,12 +21,12 @@ linters:
         - G505 # Blocklisted import crypto/md5: weak cryptographic primitive
       config:
         G306: "0644" # Poor file permissions used when writing to a new file
-  exclude-files:
-    - /zz_generated_
-    - _generated
-  exclude-dirs:
-    - generated
   exclusions:
+    paths:
+      - vendor
+      - pkg/generated
+      - .*zz_generated.*
+      - .*_generated.*
     presets:
       - comments
       - common-false-positives
@@ -39,9 +36,18 @@ linters:
       - linters:
           - staticcheck
         text: "QF1003:" # could use tagged switch on errCode (staticcheck)
+      - linters:
+          - staticcheck
+        text: "QF1007:" # could merge conditional assignment into variable declaration (staticcheck)
       - linters:
           - staticcheck
         text: "QF1008:" # could remove embedded field from selector (staticcheck)
+      - linters:
+          - staticcheck
+        text: "QF1012:" # Use fmt.Fprint(...) instead of Write([]byte(fmt.Sprint(...)))
+formatters:
+  enable:
+    - gofmt
 run:
   timeout: 5m
-  tests: true
+  tests: true

go.mod

@@ -56,7 +56,6 @@ require (
 	k8s.io/api v0.35.0
 	k8s.io/apimachinery v0.35.0
 	k8s.io/client-go v12.0.0+incompatible
-	k8s.io/utils v0.0.0-20260108192941-914a6e750570
 )
 
 require (
@@ -120,6 +119,7 @@ require (
 	k8s.io/klog/v2 v2.130.1 // indirect
 	k8s.io/kube-aggregator v0.35.0 // indirect
 	k8s.io/kube-openapi v0.31.5 // indirect
+	k8s.io/utils v0.0.0-20260108192941-914a6e750570 // indirect
 	kubevirt.io/api v1.4.0 // indirect
 	kubevirt.io/containerized-data-importer-api v1.61.0 // indirect
 	kubevirt.io/controller-lifecycle-operator-sdk/api v0.0.0-20220329064328-f3cc58c6ed90 // indirect

pkg/block/block_device.go

@@ -170,7 +170,7 @@ func udevInfo(paths *linuxpath.Paths, disk string) (map[string]string, error) {
 
 	// Look up block device in udev runtime database
 	udevID := "b" + strings.TrimSpace(string(devNo))
-	udevBytes, err := os.ReadFile(filepath.Join(paths.RunUdevData, udevID))
+	udevBytes, err := os.ReadFile(filepath.Clean(filepath.Join(paths.RunUdevData, udevID)))
 	if err != nil {
 		return nil, err
 	}

pkg/controller/blockdevice/scanner.go

@@ -13,7 +13,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/utils/strings/slices"
+	"slices"
 
 	diskv1 "github.com/harvester/node-disk-manager/pkg/apis/harvesterhci.io/v1beta1"
 	"github.com/harvester/node-disk-manager/pkg/block"

pkg/generated/clientset/versioned/fake/clientset_generated.go

@@ -37,7 +37,7 @@ type ProvisionedDisk struct {
 
 func (s *SingleDiskSuite) SetupSuite() {
 	nodeName := ""
-	f, err := os.Open(filepath.Join(os.Getenv("NDM_HOME"), "ssh-config"))
+	f, err := os.Open(filepath.Clean(filepath.Join(os.Getenv("NDM_HOME"), "ssh-config")))
 	require.Equal(s.T(), nil, err, "Open ssh-config should not get error")
 	cfg, err := ssh_config.Decode(f)
 	require.Equal(s.T(), nil, err, "Decode ssh-config should not get error")

tests/integration/test_0_single_disk_test.go

@@ -50,7 +50,7 @@ type HotPlugTestSuite struct {
 
 func (s *HotPlugTestSuite) SetupSuite() {
 	nodeName := ""
-	f, err := os.Open(filepath.Join(os.Getenv("NDM_HOME"), "ssh-config"))
+	f, err := os.Open(filepath.Clean(filepath.Join(os.Getenv("NDM_HOME"), "ssh-config")))
 	require.Equal(s.T(), nil, err, "Open ssh-config should not get error")
 	cfg, err := ssh_config.Decode(f)
 	require.Equal(s.T(), nil, err, "Decode ssh-config should not get error")
@@ -252,7 +252,7 @@ func (s *HotPlugTestSuite) Test_4_RemoveInactiveDisk() {
 func doCommand(cmdString string) (string, string, error) {
 	var stdout bytes.Buffer
 	var stderr bytes.Buffer
-	cmd := exec.Command("bash", "-c", cmdString)
+	cmd := exec.Command("bash", "-c", cmdString) //nolint:gosec // G702: intentional test helper for running shell commands
 	cmd.Stdout = &stdout
 	cmd.Stderr = &stderr
 	err := cmd.Run()

tests/integration/test_1_disk_hotplug_test.go

@@ -801,7 +801,6 @@ k8s.io/utils/internal/third_party/forked/golang/net
 k8s.io/utils/net
 k8s.io/utils/pointer
 k8s.io/utils/ptr
-k8s.io/utils/strings/slices
 k8s.io/utils/trace
 # kubevirt.io/api v1.4.0
 ## explicit; go 1.22.0