PB-2064: Fix search result test

[ismailsunni]

Test link

[cypress]

web-mapviewer    Run #6365

Run Properties:   Failed #6365  •  945ea994b7: PB-2064: split crosshair/swisssearch test in multiple tests

Project	web-mapviewer
Branch Review	fix-pb-2064-search-result-test
Run status	Failed #6365
Run duration	16m 25s
Commit	945ea994b7: PB-2064: split crosshair/swisssearch test in multiple tests
Committer	Pascal Barth
View all properties for this run ↗︎

---

Test results
Failures	47
Flaky	0
Pending	7
Skipped	3
Passing	205
View all changes introduced in this branch ↗︎

---

Tests for review

  drawing.cy.ts • 12 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them		Test Replay Screenshots
Drawing module tests > KML management > deletes the drawing when confirming the delete modal		Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer in the layer list / URL params correctly		Test Replay Screenshots
Drawing module tests > KML management > keeps the KML after a page reload, and creates a copy if it is then edited		Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup		Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup from a legacy URL		Test Replay Screenshots
Drawing module tests > KML management > receives an empty KML and can use drawing mode		Test Replay Screenshots
Drawing module tests > others > doesn't save an empty drawing (if not modified)		Test Replay Screenshots
Drawing module tests > others > can export the drawing/profile in multiple formats		Test Replay Screenshots
Drawing module tests > others > generates short links when sharing a drawing		Test Replay Screenshots
The first 10 failed tests are shown, see all 12 tests in Cypress Cloud.

  legacyParamImport.cy.ts • 6 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Test on legacy param import > Coordinates import > center where expected when given a X, Y coordinate in LV03		Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param		Test Replay Screenshots
Test on legacy param import > Layers import > don't keep KML adminId in URL after import		Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param with other layers		Test Replay Screenshots
Test on legacy param import > 3D import > transfers camera parameter from legacy URL to the new URL only heading		Test Replay Screenshots
... > Select a few features and shows the tooltip in its correct spot		Test Replay Screenshots

  3d/layers.cy.ts • 10 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Test of layer handling in 3D > add layer from search bar		Test Replay Screenshots
Test of layer handling in 3D > sets the opacity to the value defined in the layers URL param or menu UI		Test Replay Screenshots
Test of layer handling in 3D > sets the timestamp of a layer when specified in the layers URL param		Test Replay Screenshots
Test of layer handling in 3D > reorders visible layers when corresponding buttons are pressed		Test Replay Screenshots
Test of layer handling in 3D > add GeoJson layer with opacity from URL param		Test Replay Screenshots
Test of layer handling in 3D > removes a layer from the visible layers when the "remove" button is pressed		Test Replay Screenshots
Test of layer handling in 3D > uses the 3D configuration of a layer if one exists		Test Replay Screenshots
Test of layer handling in 3D > add KML layer from drawing		Test Replay Screenshots
Test of layer handling in 3D > Verify layer features in 2D and 3D		Test Replay Screenshots
Test of layer handling in 3D > Verify a layer with EPSG:4326(WEBMERCATOR) bounding box in 2D and 3D		Test Replay Screenshots

  featureSelection.cy.ts • 4 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Testing the feature selection > Feature pre-selection in the URL > Synchronise URL and feature selection		Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select an area to identify features inside it		Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select feature by click, add more feature, and deselect feature		Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can print feature information		Test Replay Screenshots

  importToolMaps.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
The Import Maps Tool > Import external WMTS layers		Test Replay Screenshots

The first 5 failed specs are shown, see all 16 specs in Cypress Cloud.

[pakb]

You shoud change all the forced void you used with something like

searchStore.setSearchQuery('', {}, dispatcher)
    .catch((error) => {
        log.error({
            title: 'Some title',
            messages: ['Error while searching', error]
        })
    })

The ESLint/TS error that is raised there should then disappear (no need to .then everything, but you at least need to catch the errors of the promise you create)

[pakb]

Code looks good, now I think you still have to fix some stuff, here's what I get locally (as the CI is failing to run it)

[ismailsunni]

@pakb, it turns out that there is a change in the search API (translation) and a different proj4 instance in api and coordinate (no Swiss CRS). Also, for the mouseenter and mouseleave, I can't make should work, so I kept the wrap back. Other tests still use should

[ismailsunni]

strangely, the search result tests are running so long...

[ismailsunni]

@pakb, the tests pass locally, but I need to run them one by one. If I run all 3 tests together, my cypress cries and the test cann't be run because timeout

[pakb]

splitting the last test fixed the file 🎉