PB-2064: fix drawing module

[sommerfe]

Test link

[pakb]

Looks like you have based your work on #1546 you should switch the base of your PR

[pakb]

I had mixed result with this, calling OL register inside a bundled lib.
It looked like the proj4 instance we are altering here can be different from the one OL then receives in the overlying app (the one importing this piece of code).

[sommerfe]

Do you have a suggestion on how i can do it differently? the problem is that the EPSG:2056 is missing when calling the parseKML function from the kmlUtils. So the drawing is not visible as the KML coordinates can not be converted.

[cypress]

web-mapviewer    Run #6369

Run Properties:   Failed #6369  •  457a1378d4: PB-2064: fix lint

Project	web-mapviewer
Branch Review	fix-pb-2064-drawing-module
Run status	Failed #6369
Run duration	19m 27s
Commit	457a1378d4: PB-2064: fix lint
Committer	Felix Sommer
View all properties for this run ↗︎

---

Test results
Failures	48
Flaky	0
Pending	7
Skipped	0
Passing	207
View all changes introduced in this branch ↗︎

---

Tests for review

  drawing.cy.ts • 14 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them		Test Replay Screenshots
Drawing module tests > Drawing mode/tools > can create annotation/text and edit them		Test Replay Screenshots
Drawing module tests > Drawing mode/tools > can create line / measurement, extend it, and delete the last node by right click / button, and make a polygon		Test Replay Screenshots
Drawing module tests > Drawing mode/tools > can create line/polygons and edit them		Test Replay Screenshots
Drawing module tests > KML management > deletes the drawing when confirming the delete modal		Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer in the layer list / URL params correctly		Test Replay Screenshots
Drawing module tests > KML management > keeps the KML after a page reload, and creates a copy if it is then edited		Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup		Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup from a legacy URL		Test Replay Screenshots
Drawing module tests > KML management > receives an empty KML and can use drawing mode		Test Replay Screenshots
The first 10 failed tests are shown, see all 14 tests in Cypress Cloud.

  legacyParamImport.cy.ts • 6 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Test on legacy param import > Coordinates import > center where expected when given a X, Y coordinate in LV03		Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param		Test Replay Screenshots
Test on legacy param import > Layers import > don't keep KML adminId in URL after import		Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param with other layers		Test Replay Screenshots
Test on legacy param import > 3D import > transfers camera parameter from legacy URL to the new URL only heading		Test Replay Screenshots
... > Select a few features and shows the tooltip in its correct spot		Test Replay Screenshots

  3d/layers.cy.ts • 10 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Test of layer handling in 3D > add layer from search bar		Test Replay Screenshots
Test of layer handling in 3D > sets the opacity to the value defined in the layers URL param or menu UI		Test Replay Screenshots
Test of layer handling in 3D > sets the timestamp of a layer when specified in the layers URL param		Test Replay Screenshots
Test of layer handling in 3D > reorders visible layers when corresponding buttons are pressed		Test Replay Screenshots
Test of layer handling in 3D > add GeoJson layer with opacity from URL param		Test Replay Screenshots
Test of layer handling in 3D > removes a layer from the visible layers when the "remove" button is pressed		Test Replay Screenshots
Test of layer handling in 3D > uses the 3D configuration of a layer if one exists		Test Replay Screenshots
Test of layer handling in 3D > add KML layer from drawing		Test Replay Screenshots
Test of layer handling in 3D > Verify layer features in 2D and 3D		Test Replay Screenshots
Test of layer handling in 3D > Verify a layer with EPSG:4326(WEBMERCATOR) bounding box in 2D and 3D		Test Replay Screenshots

  featureSelection.cy.ts • 4 failed tests • e2e/chrome/mobile

View Output

Test		Artifacts
Testing the feature selection > Feature pre-selection in the URL > Synchronise URL and feature selection		Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select an area to identify features inside it		Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select feature by click, add more feature, and deselect feature		Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can print feature information		Test Replay Screenshots

  importToolMaps.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test		Artifacts
The Import Maps Tool > Import external WMTS layers		Test Replay Screenshots

The first 5 failed specs are shown, see all 15 specs in Cypress Cloud.