Add some tests for polymorphic links and QB.#945
Merged
vpetrovykh merged 1 commit intomasterfrom Oct 2, 2025
Merged
Conversation
Overall the polymorphic links seem to work in various combinations. There are some issues with typing, though.
Contributor
Author
|
This is related to testing #633 |
msullivan
approved these changes
Oct 2, 2025
msullivan
added a commit
that referenced
this pull request
Oct 3, 2025
PR #945 added a bunch of tests with @skip_typecheck, but I *think* the type errors were legitimate (the `item` link is `optional`), so I'm adding asserts to the python and removing the `@skip_typecheck`s. Am I missing something being wrong here?
vpetrovykh
pushed a commit
that referenced
this pull request
Oct 4, 2025
PR #945 added a bunch of tests with @skip_typecheck, but I *think* the type errors were legitimate (the `item` link is `optional`), so I'm adding asserts to the python and removing the `@skip_typecheck`s. Am I missing something being wrong here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall the polymorphic links seem to work in various combinations. There are some issues with typing, though.