Skip to content

Commit da21100

Browse files
msullivanvpetrovykh
authored andcommitted
Remove @skip_typechecks on several tests
PR #945 added a bunch of tests with @skip_typecheck, but I *think* the type errors were legitimate (the `item` link is `optional`), so I'm adding asserts to the python and removing the `@skip_typecheck`s. Am I missing something being wrong here?
1 parent 6402540 commit da21100

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/test_qb.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,7 +1163,6 @@ def test_qb_poly_01(self):
11631163
self.assertEqual(p.name, "Alice")
11641164
self.assertIsNone(p.item)
11651165

1166-
@tb.skip_typecheck
11671166
def test_qb_poly_02(self):
11681167
from models.orm_qb import default
11691168

@@ -1182,11 +1181,11 @@ def test_qb_poly_02(self):
11821181
)
11831182

11841183
self.assertEqual(p.name, "Billie")
1184+
assert p.item
11851185
self.assertEqual(p.item.name, "nice bag")
11861186
self.assertEqual(p.item.contents, [])
11871187
self.assertIsInstance(p.item, default.Bag)
11881188

1189-
@tb.skip_typecheck
11901189
def test_qb_poly_03(self):
11911190
from models.orm_qb import default
11921191

@@ -1205,6 +1204,7 @@ def test_qb_poly_03(self):
12051204
)
12061205

12071206
self.assertEqual(p.name, "Cameron")
1207+
assert p.item
12081208
self.assertEqual(p.item.name, "big box")
12091209
self.assertIsInstance(p.item, default.Box)
12101210

@@ -1218,7 +1218,6 @@ def test_qb_poly_03(self):
12181218
self.assertEqual(c.name, name)
12191219
self.assertIsInstance(c, t)
12201220

1221-
@tb.skip_typecheck
12221221
def test_qb_poly_04(self):
12231222
from models.orm_qb import default
12241223

@@ -1237,6 +1236,7 @@ def test_qb_poly_04(self):
12371236
)
12381237

12391238
self.assertEqual(p.name, "Dana")
1239+
assert p.item
12401240
self.assertEqual(p.item.name, "round tin")
12411241
self.assertIsInstance(p.item, default.Tin)
12421242

@@ -1250,7 +1250,6 @@ def test_qb_poly_04(self):
12501250
self.assertEqual(c.name, name)
12511251
self.assertIsInstance(c, t)
12521252

1253-
@tb.skip_typecheck
12541253
def test_qb_poly_05(self):
12551254
from models.orm_qb import default
12561255

@@ -1269,6 +1268,7 @@ def test_qb_poly_05(self):
12691268
)
12701269

12711270
self.assertEqual(p.name, "Elsa")
1271+
assert p.item
12721272
self.assertEqual(p.item.name, "package")
12731273
self.assertIsInstance(p.item, default.Box)
12741274

@@ -1284,7 +1284,6 @@ def test_qb_poly_05(self):
12841284
self.assertEqual(c.name, name)
12851285
self.assertIsInstance(c, t)
12861286

1287-
@tb.skip_typecheck
12881287
def test_qb_poly_06(self):
12891288
from models.orm_qb import default
12901289

@@ -1303,6 +1302,7 @@ def test_qb_poly_06(self):
13031302
)
13041303

13051304
self.assertEqual(p.name, "Zoe")
1305+
assert p.item
13061306
self.assertEqual(p.item.name, "fancy")
13071307
self.assertIsInstance(p.item, default.GiftBox)
13081308

0 commit comments

Comments
 (0)