Skip to content

Convert unnecessary soft error to debug logging (#1291) #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scottcao wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Convert unnecessary soft error to debug logging (#1291) #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5854ab
Don't unwrap soft error invocations from materializer
scottcao Apr 11, 2026
8890789
Convert unnecessary soft error to debug logging (#1291)
scottcao Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/buck2_execute_impl/src/materializers/deferred/artifact_tree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use std::sync::Arc;

use buck2_core::fs::project_rel_path::ProjectRelativePathBuf;
use buck2_core::soft_error;
use buck2_directory::directory::directory_ref::DirectoryRef;
use buck2_directory::directory::entry::DirectoryEntry;
use buck2_error::BuckErrorContext;
Expand Down Expand Up @@ -359,8 +358,7 @@ impl ArtifactTree {
}
}
Err(e) => {
// NOTE: This shouldn't normally happen?
soft_error!("cleanup_finished_vacant", e, quiet: true).unwrap();
tracing::debug!("cleanup_finished_vacant: {}", e);
}
}
}
Expand Down
14 changes: 6 additions & 8 deletions app/buck2_execute_impl/src/materializers/deferred/command_processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,12 +548,11 @@ impl<T: IoHandler> DeferredMaterializerCommandProcessor<T> {
Some(cmd.create_clean_fut(&mut self, None, daemon_id));
} else {
// This should never happen
soft_error!(
let _unused = soft_error!(
"clean_stale_no_config",
buck2_error!(buck2_error::ErrorTag::Tier0, "clean scheduled without being configured"),
quiet: true
)
.unwrap();
);
}
}
}
Expand Down Expand Up @@ -751,12 +750,11 @@ impl<T: IoHandler> DeferredMaterializerCommandProcessor<T> {
.materializer_state_table()
.update_access_times(buffer.iter().collect::<Vec<_>>())
{
soft_error!(
let _unused = soft_error!(
"materializer_materialize_error",
e,
quiet: true
)
.unwrap();
);
return "Found error while updating access times in sqlite db".to_owned();
}
}
Expand Down Expand Up @@ -1021,7 +1019,7 @@ impl<T: IoHandler> DeferredMaterializerCommandProcessor<T> {
.materializer_state_table()
.update_access_times(vec![&path])
{
soft_error!("has_artifact_update_time", e, quiet: true).unwrap();
let _unused = soft_error!("has_artifact_update_time", e, quiet: true);
}
}
}
Expand Down Expand Up @@ -1457,7 +1455,7 @@ fn on_materialization(
.materializer_state_table()
.insert(path, metadata, timestamp)
{
soft_error!(error_name, e, quiet: true).unwrap();
let _unused = soft_error!(error_name, e, quiet: true);
}
}

Expand Down
Loading