Convert unnecessary soft error to debug logging (#1291)#1291
Open
scottcao wants to merge 2 commits intofacebook:mainfrom
Open
Convert unnecessary soft error to debug logging (#1291)#1291scottcao wants to merge 2 commits intofacebook:mainfrom
scottcao wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
@scottcao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100418271. |
meta-codesync
bot
changed the title
scottcao
added a commit
to scottcao/buck2
that referenced
this pull request
Apr 11, 2026
Summary: It's entirely possible for paths to be re-declared by a subsequent command before cleanup path request gets processed. Not sure why a soft error was added here but it's too broad for detecting bugs in materializer. Differential Revision: D100418271
scottcao
force-pushed
the
export-D100418271
branch
from
e712e97 to
635c428
Compare
Summary: These should not cause panics in OSS. Differential Revision: D100422870
Summary: Pull Request resolved: facebook#1291 It's entirely possible for paths to be re-declared by a subsequent command before cleanup path request gets processed. Not sure why a soft error was added here but it's too broad for detecting bugs in materializer. Differential Revision: D100418271
scottcao
force-pushed
the
export-D100418271
branch
from
635c428 to
8890789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It's entirely possible for paths to be re-declared by a subsequent command before cleanup path request gets processed. Not sure why a soft error was added here but it's too broad for detecting bugs in materializer.
Differential Revision: D100418271