Skip to content

Remove ErtPluginManager arg from main fns#13220

Open
oyvindeide wants to merge 1 commit intoequinor:mainfrom
oyvindeide:plugins_move
Open

Remove ErtPluginManager arg from main fns#13220
oyvindeide wants to merge 1 commit intoequinor:mainfrom
oyvindeide:plugins_move

Conversation

@oyvindeide
Copy link
Copy Markdown
Collaborator

@oyvindeide oyvindeide commented Mar 30, 2026

added manual call to pass the global
logger to consumer plugins

Copy of: https://github.com/equinor/ert/pull/11803/changes

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

added manual call to pass the global
logger to consumer plugins
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.28%. Comparing base (abdf162) to head (c520500).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/__main__.py 80.00% 1 Missing ⚠️
src/ert/gui/main.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13220      +/-   ##
==========================================
- Coverage   90.32%   90.28%   -0.05%     
==========================================
  Files         453      453              
  Lines       31304    31326      +22     
==========================================
+ Hits        28275    28282       +7     
- Misses       3029     3044      +15     
Flag Coverage Δ
cli-tests 37.56% <38.88%> (+<0.01%) ⬆️
gui-tests 67.46% <83.33%> (+<0.01%) ⬆️
performance-and-unit-tests 77.78% <88.88%> (-0.06%) ⬇️
test 46.44% <22.22%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oyvindeide oyvindeide added the release-notes:improvement Automatically categorise as improvement in release notes label Mar 30, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 30, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing oyvindeide:plugins_move (c520500) with main (a6fa26d)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:improvement Automatically categorise as improvement in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants