Remove ErtPluginManager arg from main fns#11803
Closed
yngve-sk wants to merge 1 commit intoequinor:mainfrom
Closed
Remove ErtPluginManager arg from main fns#11803yngve-sk wants to merge 1 commit intoequinor:mainfrom
yngve-sk wants to merge 1 commit intoequinor:mainfrom
Conversation
CodSpeed Performance ReportMerging #11803 will not alter performanceComparing Summary
|
ae57d2b to
9a5685d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11803 +/- ##
==========================================
- Coverage 90.70% 90.67% -0.03%
==========================================
Files 431 431
Lines 29606 29602 -4
==========================================
- Hits 26853 26841 -12
- Misses 2753 2761 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0fa6731 to
d21f8d4
Compare
added manual call to pass the global logger to consumer plugins
d21f8d4 to
d6b6313
Compare
Collaborator
|
Closing, been picked up in: #13220 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added manual call to pass the global
logger to consumer plugins
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable