Merged
Conversation
Contributor
Author
|
With the landing of embassy-rs/nxp-pac#30, this change is also ready to be reviewed for landing. |
i509VCB
approved these changes
Mar 11, 2026
wt
force-pushed
the
add_lpc55s16
branch
5 times, most recently
from
0f5dab0 to
dd9aaac
Compare
Contributor
Author
|
I moved this back to draft as I found a bug in nxp-pac that prevents this change from working. See embassy-rs/nxp-pac#56 |
Contributor
Author
|
The nxp-pac change was landed and I updated this change to use that new commit id, so it's ready for review again. |
This will get my change to the nxp-pac so that I can add LPC55S16 support. I also moved the repo to the embassy-rs org's repo.
All the USART pins were changed to only be enabled if relevant pins are defined in a chip's metadata. This will allow us to update nxp-pac with metadata and simply update the dependent version in this crate to get access to those pin traits. The CTS/RTS/SCK pins are not yet wired up in the usart driver, so I've annotated them with `#[allow(unused)]` in the meantime.
The dma, pint, and gpio initialization as implemented for lpc55-core0 is also applicable to LPC55S16. As a result, we should run the init for all lpc55 family chips.
i509VCB
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a a draft of my work to add lpc55s16 support. This currently depends on embassy-rs/nxp-pac#30 to land and this embassy-nxp dependencies to be updated afterwards.