Add algorithms for F_LOWER_BOUND and F_UPPER_BOUND as Simple FB#2373
Open
franz-hoepfinger-4diac wants to merge 1 commit intoeclipse-4diac:developfrom
Open
Add algorithms for F_LOWER_BOUND and F_UPPER_BOUND as Simple FB#2373franz-hoepfinger-4diac wants to merge 1 commit intoeclipse-4diac:developfrom
franz-hoepfinger-4diac wants to merge 1 commit intoeclipse-4diac:developfrom
Conversation
franz-hoepfinger-4diac
force-pushed
the
feature/a7
branch
from
0b3e5c7 to
a67136f
Compare
Contributor
Contributor
|
#2332 (review) Should we provide a default value for the dimension so that users that want to work with 1 dimensional arrays do not need to set a value. I think this is the main use case and would make the usage of the block much easier. 
--> i did already. |
Reclassify F_LOWER_BOUND and F_UPPER_BOUND into arrays package
franz-hoepfinger-4diac
force-pushed
the
feature/a7
branch
from
7991d6b to
9980618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We agreed to make IEC 61131-3 FBs as Simple FBs here: #2082 (review)
this PR converts these 2 into a Simple FB.
#2046 (comment) the Question is if "select" should stay as Package, or better "array" ?
references:
#2342
#2046