Adds lower and upper bound function blocks#2046
Conversation
Test Results 110 files ±0 110 suites ±0 1m 6s ⏱️ -4s Results for commit ae9abcf. ± Comparison against base commit 0f31d38. This pull request removes 29 and adds 11 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
ANY_INT as OUT seems unwise here. Better UINT ? right ? |
|
As upper and lower array bounds could be either positive or negative and in general larger than the range of UINT, ANY_INT is the correct choice |
I agree. now i have to learn, how do we handle a ANY_INT on the FORTE Level. |
mx990
left a comment
There was a problem hiding this comment.
I believe these should be part of the iec61131-3 standard library, since both are defined in the IEC 61131-3 standard. I am not sure in which folder/package, however, since they are defined separately in section 6.5.3. Maybe selection would be a good fit?
85acfe6 to
12e860e
Compare
mx990
left a comment
There was a problem hiding this comment.
Please rebase your branch to remove the unrelated commit.
12e860e to
98e25d7
Compare
Introduces F_LOWER_BOUND and F_UPPER_BOUND XML configurations to compute the lower and upper bounds of array dimensions. Includes event inputs/outputs and variable declarations for precise functionality. v .
98e25d7 to
ae9abcf
Compare
|
@MartinMelikMerkumians should this stay in "selection" or move to "Array" ? |
I didn't want to challenge an already merged PR. If it was already agreed that it is selection, then it's ok for me. If its open for discussion, I would move it to a dedicated array functions package. |
|
as we need to touch it anyhow, we could move it ! ? |
|
After thinking some more on this, I also believe we should move it to a dedicated |
|
I was a bit reluctant to change this but as the two blocks where anyhow not usable as the 4diac FORTE implementation is missing I also agree to move to the |
Here you go: |
Introduces F_LOWER_BOUND and F_UPPER_BOUND XML configurations
to compute the lower and upper bounds of array dimensions.
Includes event inputs/outputs and variable declarations
for precise functionality.