replace unmaintained 'encoding' crate with 'encoding_rs' (RUSTSEC-2021-0153)#20
Merged
dacut merged 1 commit intodacut:mainfrom Mar 31, 2026
Merged
Conversation
Contributor
Author
|
@dacut can you pleeeeeeeeeeease merge this ? This being an active RUSTSEC vulnerability flagging all downstream projects during CI audits, it would be highly appreciated |
Owner
|
Looking at this now, @HatemMn |
Owner
|
(Strange that I'm not getting GitHub vulnerability report for this; thanks for flagging it!) |
Owner
|
Running |
Owner
|
Bah, I forgot that |
Owner
|
Verifying that the tests still pass... |
Owner
|
Alright, this has been pushed to crates.io as version 0.11.4. Thanks again! |
Contributor
Author
|
@dacut thanks m8 for your responsiveness ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Context: This PR replaces the encoding crate with encoding_rs to resolve the security advisory RUSTSEC-2021-0153. The original encoding crate has been unmaintained since 2016 and causes cargo audit / deny to fail in downstream projects that rely on scratchstack-aws-signature.
Changes Made:
I've kept the changes to the absolute minimum necessary to make the project compile and pass tests again
You can read the diffs, there isn't much