Skip to content

fix: fixing some audit issues#866

Closed
HatemMn wants to merge 3 commits intodevelopfrom
fix/rust_audit_issues
Closed

fix: fixing some audit issues#866
HatemMn wants to merge 3 commits intodevelopfrom
fix/rust_audit_issues

Conversation

@HatemMn
Copy link
Copy Markdown
Contributor

@HatemMn HatemMn commented Mar 30, 2026

FIX 1

Fixes

{ id = "RUSTSEC-2025-0009", reason = "Pinned to scratchstack-aws-signature 0.10 (Feb 2026) which depends on ring 0.16.x" },

to

{ id = "RUSTSEC-2021-0153", reason = "scratchstack-aws-signature 0.11.3 (latest) depends on the unmaintained encoding 0.2.33 crate" },

RUSTSEC-2025-0009 is a vulenaribility which makes the other rustsec less "important" to fix

I submited a PR to update this encoding library dacut/scratchstack-aws-signature#20

FIX 2

There is also another warning : I submitted a fix PR and the maintainer was quick to react and accept it :

blackbeam/mysql_async#390

This was done by following this migration : https://docs.rs/scratchstack-aws-signature/0.11.3/scratchstack_aws_signature/migration/index.html

NOTE : the only "difference" is that the timeout that used to be 5 minutes is now also delegated to the libray and is now 15 minutes instead by default which is more permissive and hence ok

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses dependency audit findings by updating Rust dependencies (notably scratchstack-aws-signature and mysql_async), adjusting the AWS XKS SigV4 middleware to the new scratchstack-aws-signature validation API, and refreshing Nix vendor hashes accordingly.

Changes:

  • Update scratchstack-aws-signature to 0.11 (and related lockfile updates) and adjust AWS XKS SigV4 request validation code to match the new API.
  • Update mysql_async to 0.36.2 and enable jsonwebtoken’s use_pem feature.
  • Refresh Nix expected vendor hashes and update cargo-deny advisory ignore configuration.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
nix/expected-hashes/ui.vendor.non-fips.sha256 Updated Nix vendoring hash for non-FIPS UI inputs.
nix/expected-hashes/ui.vendor.fips.sha256 Updated Nix vendoring hash for FIPS UI inputs.
nix/expected-hashes/ui.pnpm.linux.sha256 Updated Nix pnpm dependency hash (Linux).
nix/expected-hashes/ui.pnpm.darwin.sha256 Updated Nix pnpm dependency hash (macOS).
nix/expected-hashes/server.vendor.static.sha256 Updated Nix vendoring hash for server static build inputs.
nix/expected-hashes/cli.vendor.linux.sha256 Updated Nix vendoring hash for CLI inputs (Linux).
deny.toml Adjusted ignored RustSec advisory to match updated dependency graph.
crate/server/src/routes/aws_xks/sigv4_middleware.rs Migrated SigV4 verification to sigv4_validate_request flow.
crate/server_database/Cargo.toml Bumped mysql_async patch version.
Cargo.toml Updated scratchstack-aws-signature version and enabled jsonwebtoken use_pem.
Cargo.lock Lockfile refresh reflecting dependency upgrades and transitive changes.

Comment thread crate/server/src/routes/aws_xks/sigv4_middleware.rs
Comment thread crate/server/src/routes/aws_xks/sigv4_middleware.rs
Comment thread crate/server/src/routes/aws_xks/sigv4_middleware.rs
@dacut
Copy link
Copy Markdown

dacut commented Mar 31, 2026

dacut/scratchstack-aws-signature#20 has been merged and a version 0.11.4 of scratchstack-aws-signature has been pushed to crates.io.

Comment thread Cargo.toml
rand = "0.9"
reqwest = { version = "0.12", default-features = false }
scratchstack-aws-signature = "=0.10" # Must stay 0.10 for now (Feb 2026)
scratchstack-aws-signature = "0.11"
Copy link
Copy Markdown
Contributor

@Manuthor Manuthor Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the comment says, it must stay on 0.10 for now. @bgrieder did not upgrade on 0.11 on purpose. Especially now we did the real tests with s3 environment and other AWS services.

@HatemMn
Copy link
Copy Markdown
Contributor Author

HatemMn commented Apr 1, 2026

it's easier to restart a new PR than fix this one, opening #876

and closing this

@HatemMn HatemMn closed this Apr 1, 2026
@Manuthor Manuthor deleted the fix/rust_audit_issues branch April 9, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants