Skip to content

docs: Excel/Sheets add-in refresh-all, drag-to-Filters, and folder deletion - #11765

Merged
vasilev-alex merged 5 commits into
masterfrom
claude/sheets-add-in-docs-sweep-25362
Sep 4, 2026
Merged

docs: Excel/Sheets add-in refresh-all, drag-to-Filters, and folder deletion#11765
vasilev-alex merged 5 commits into
masterfrom
claude/sheets-add-in-docs-sweep-25362

Conversation

@vasilev-alex

Copy link
Copy Markdown
Member

Check List

  • Docs have been added / updated if required
  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

Description of Changes Made

A batch of documentation updates to the Excel/Google Sheets add-in pages and the folders page, catching up to recently shipped product behavior:

  • The pivot builder's drag-and-drop now also accepts the Filters zone (previously Rows/Columns/Measures only); a member dropped there with no value yet shows greyed until you give it one.
  • An unsaved exploration can be deleted straight from the editor's own actions menu, not only from a list view.
  • The workbook/spreadsheet home explicitly documents that a sheet isn't limited to one placed exploration.
  • Refresh all is now a tracked run with a progress footer (count + Stop button) and per-row states, rather than a single spinner-and-toast action.
  • A banner now warns before Refresh overwrites cells that were edited by hand since the last write, with a button to jump to them.
  • Workbook-home placement-state labels updated to match the current UI: "Out of date" (previously described as a "Stale" tag) and "Not saved" (previously "Unsaved"); they're no longer shown as colored tags.
  • Deleting a non-empty folder now deletes its contents (with a confirmation step) instead of being blocked until it's emptied first.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GuYqSYDJ9NP1xSsSuFyC7c


Generated by Claude Code

…letion

- The pivot builder's Rows/Columns/Measures drag now also accepts Filters,
  with an unapplied filter shown greyed until given a value.
- An unsaved exploration can be deleted from the editor's own menu.
- Document workbook homes as not limited to one placed exploration per sheet.
- "Refresh all" runs as a tracked, resumable operation with a progress
  footer and per-row states, and a banner now warns before Refresh
  overwrites cells edited by hand.
- Relabel workbook-home placement states to match the current UI: "Out of
  date" (was "Stale") and "Not saved" (was "Unsaved"), no longer shown as
  colored tags.
- Deleting a non-empty folder now deletes its contents with confirmation,
  instead of being blocked until it's emptied.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GuYqSYDJ9NP1xSsSuFyC7c
@mintlify

mintlify Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
cubed3 🟢 Ready View Preview Sep 4, 2026, 12:37 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished @vasilev-alex's task in 1m 59s —— View job


Docs review — 1 medium, 4 low. Excel/Sheets parity is clean; one factual slip in folders.mdx.

Full review (5 inline comments)
  • Gather context (diff, changed files)
  • Check existing review threads (none existed)
  • Review docs changes for accuracy, consistency, and conventions
  • Post review

What's good

  • Excel/Sheets parity is exact. Every one of the seven changes lands in both files with only the workbook/spreadsheet noun swapped. That's the failure mode these two pages are most prone to, and it's clean here.
  • The rewritten "Work with explorations" paragraph is a genuine accuracy improvement — "Out of date" / "Not saved" as plain state text rather than "tags" matches how the pane actually renders.
  • greyed and **⋮** menu both match existing precedent elsewhere in the docs (charts/chart-types/funnel.mdx, dashboards/index.mdx), so no new inconsistency introduced.
  • No <Frame>/component misuse, no new H1s, no legacy "Cube Cloud" naming added, internal links unchanged. /docs-mintlify is the correct (active) site per CLAUDE.md.

Findings

# Severity File Issue
1 Medium folders.mdx:128 Lists reports as folder content that deletion removes. Contradicts the page's own "What can go in a folder" (Workbooks / Dashboards / Explorations) and sharing.mdx:104. Per the taxonomy in docs-mintlify/CLAUDE.md, a report lives inside a workbook tab, not directly in a folder.
2 Low folders.mdx:127-135 Emphasis inverted — the irreversible cascade is plain prose while the <Warning> carries a permission precondition that prevents data loss. Also, "Full access to everything inside the folder" implies per-item permissions the page's own table doesn't define.
3 Low microsoft-excel.mdx:95-98, google-sheets.mdx:87-90 "use the funnel buttons … the same way" — clicking a funnel isn't dragging, so the referent is unclear; the original two-sentence form was clearer. Plus Filters is called a "tab" here but a "pane" nine lines below.
4 Low microsoft-excel.mdx:155-157, Sheets equivalent Not saved and Unsaved in adjacent clauses read as a typo rather than two distinct labels. Worth making the contrast explicit if both are really on screen.
5 Low microsoft-excel.mdx:174-183, Sheets equivalent Two new UI surfaces (progress footer, overwrite banner) with no {/* TODO: screenshot — ... */} placeholder, which docs-mintlify/CLAUDE.md calls for. "a large workbook takes a while" is also vaguer than it needs to be.

Not applicable

Security, performance, and test-coverage review are moot — this PR is documentation prose only, with no code, config, or navigation (docs.json) changes. No new pages were added, so no sidebar registration is needed. I did not run the Mintlify dev server; the edits are prose-only within existing MDX blocks, so there's no new syntax that could break the build.

I could not verify the underlying product claims (the Filters drop zone, the tracked Refresh all run, the folder cascade-delete behavior) against the actual add-in or workspace UI — those need confirmation from someone with the shipped build.

· [`claude/sheets-add-in-docs-sweep-25362`](https://github.com/cube-js/cube/tree/claude/sheets-add-in-docs-sweep-25362)

Comment thread docs-mintlify/docs/organize-content/folders.mdx Outdated
Comment thread docs-mintlify/docs/organize-content/folders.mdx Outdated
Comment thread docs-mintlify/docs/integrations/microsoft-excel.mdx Outdated
Comment thread docs-mintlify/docs/integrations/microsoft-excel.mdx Outdated
Comment thread docs-mintlify/docs/integrations/microsoft-excel.mdx
- Fix folder content taxonomy: explorations, not reports.
- Put the destructive cascade in the Warning callout; ground the
  permission precondition in per-subfolder permissions instead of an
  undefined "access to everything inside" notion.
- Disambiguate the funnel-button clause and use "Filters pane" (matching
  the page's existing terminology) instead of "Filters tab".
- Make the Not saved / Unsaved contrast explicit instead of reading like
  a typo.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GuYqSYDJ9NP1xSsSuFyC7c
@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Claude Code is working…

I'll analyze this and get back to you.

View job run

@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished @vasilev-alex's task in 1m 20s —— View job


Docs review (round 2) — all 5 prior findings addressed. 2 low nits remain, both in folders.mdx/wrapping.

Full review (1 inline comment)
  • Gather context (diff, changed files)
  • Check existing review threads (all 5 prior threads already resolved by the author's follow-up commits)
  • Re-review the updated diff
  • Post review

Prior findings — status

# Prior finding Status
1 folders.mdx listed reports as folder content ✅ Fixed — now "subfolders, workbooks, dashboards, and explorations", matching What can go in a folder and sharing.mdx:104
2 Emphasis inverted — cascade in prose, permission note in <Warning> ✅ Fixed — the irreversible cascade is now the <Warning>; the permission precondition demoted to prose
3 "the same way" ambiguity + "Filters tab" vs "pane" ✅ Fixed — "or click the funnel buttons to add members to Filters", and Filters pane now matches line 104
4 Not saved vs Unsaved read as a typo ✅ Fixed — the contrast is now explicit (under its sheet vs. a top-level heading when there's no sheet/anchor)
5 No screenshot placeholder for the new UI surfaces; vague timing hedge ✅ Fixed — {/* TODO: screenshot — the hand-edit overwrite banner… */} added to both pages, and "takes a while" replaced with "a workbook with many sheets refreshes noticeably slower than a single placement"

Verification

I normalized the workbook/spreadsheet and add-in/add-on nouns and compared the two integration pages section by section: parity is exact across all seven changes, including the new screenshot placeholder. That's the failure mode these two pages are most prone to, and it's clean.

greyed, **⋮** menu, and the {/* TODO: screenshot — ... */} form all match existing precedent. No new H1s, no <Frame>/component misuse, no legacy "Cube Cloud" naming, no docs.json change needed (no new pages).

Remaining nits (both low)

  1. folders.mdx:134-135 — inline comment posted. The new prose sentence has a dangling "it" (antecedent now sits inside the <Warning> above), and scoping the block to subfolders may be narrower than the real rule: sharing.mdx:117 says direct permissions override inherited ones for any content type, so a workbook or dashboard with its own permissions would presumably block deletion identically.

  2. Stray mid-paragraph line breakmicrosoft-excel.mdx:158-159 and google-sheets.mdx:150-151: "…resumes exactly where you left off." ends a short line, then "The pane can also hold…" starts a new one, mid-paragraph. Renders identically in MDX; it just breaks the ~76-col wrap the rest of the file keeps. Purely cosmetic — mentioning rather than commenting inline.

Not applicable

Security, performance, and test-coverage review are moot — documentation prose only, no code or config. I did not run the Mintlify dev server; the edits are prose inside existing MDX blocks plus two MDX comments, so there's no new syntax that could break the build.

I still could not verify the underlying product claims (the Filters drop zone, the tracked Refresh all run, the sheet-at-a-time write ordering, the folder cascade-delete and its permission precondition) against a shipped build — those need confirmation from someone with the product in hand.

· [`claude/sheets-add-in-docs-sweep-25362`](https://github.com/cube-js/cube/tree/claude/sheets-add-in-docs-sweep-25362)

Comment thread docs-mintlify/docs/organize-content/folders.mdx Outdated
… rule

Match the direct-permissions-override-inherited rule documented in
sharing.mdx: any content type can carry its own permissions, not just
subfolders.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GuYqSYDJ9NP1xSsSuFyC7c
@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Re-reviewing after new commits

  • Gather context (diff vs origin/master)
  • Check prior review threads / resolve stale ones
  • Verify each earlier finding against the current diff
  • Post review

View job run · claude/sheets-add-in-docs-sweep-25362

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GuYqSYDJ9NP1xSsSuFyC7c
@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished @vasilev-alex's task in 50s —— View job


Docs review (round 3) — no new findings. All 6 prior threads resolved and verified fixed; ✅ ready from a docs-review standpoint.

Full review
  • Gather context (diff vs origin/master, changed files)
  • Check existing review threads (all 6 already resolved)
  • Re-review the updated diff
  • Post review

What changed since round 2

Two follow-up commits landed:

  • 6902159folders.mdx:134-135 now reads "If anything inside the folder has its own permissions…", fixing the dangling "it" and broadening the rule from subfolders to any content type, matching the direct-permissions-override rule in sharing.mdx:117.
  • 96506c5 — the stray mid-paragraph wrap at microsoft-excel.mdx:158 / google-sheets.mdx:150 is gone; the paragraph now wraps consistently with the rest of the file.

Both round-2 nits are resolved. No new prose was introduced by either commit beyond those fixes.

Verification

Check Result
Excel ↔ Sheets parity ✅ Exact across all seven changes, including the screenshot placeholder — only the workbook/spreadsheet and add-in/add-on nouns differ
folders.mdx internal consistency ✅ "subfolders, workbooks, dashboards, and explorations" matches What can go in a folder (folders.mdx:51-57) and sharing.mdx:104
Callout emphasis ✅ The irreversible cascade is the <Warning>; the permission precondition is plain prose below it
Terminology Filters is consistently a pane (microsoft-excel.mdx:97 vs :104); greyed and **⋮** menu match existing precedent
Conventions ✅ No new H1s, no <Frame>/component misuse, no legacy "Cube Cloud" naming added, no new pages so no docs.json change needed, /docs-mintlify is the correct active site per CLAUDE.md
Screenshot placeholders {/* TODO: screenshot — ... */} present on both pages, matching the form used at microsoft-excel.mdx:133

Aside (pre-existing, not this PR)

google-sheets.mdx:106 says "Cube Cloud for Sheets", which is the legacy naming docs-mintlify/CLAUDE.md asks to avoid in new content. It predates this PR and isn't in the diff, so it's out of scope here — flagging only in case someone wants a separate cleanup pass across the integrations pages. Fix this →

Not applicable

Security, performance, and test-coverage review are moot — documentation prose only, no code or config. I did not run the Mintlify dev server; the edits are prose inside existing MDX blocks plus two MDX comments, so there's no new syntax that could break the build. The Mintlify preview deployment reports 🟢 Ready.

I still could not verify the underlying product claims (the Filters drop zone, the tracked Refresh all run, the sheet-at-a-time write ordering, the Not saved / Unsaved label split, the folder cascade-delete and its permission precondition) against a shipped build — those need confirmation from someone with the product in hand.

· [`claude/sheets-add-in-docs-sweep-25362`](https://github.com/cube-js/cube/tree/claude/sheets-add-in-docs-sweep-25362)

@vasilev-alex
vasilev-alex merged commit fe08940 into master Sep 4, 2026
9 checks passed
@vasilev-alex
vasilev-alex deleted the claude/sheets-add-in-docs-sweep-25362 branch September 4, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants