fix: initialize model language filter from user preference (#1265) - #1309
Closed
ChristophNoetel wants to merge 1 commit into
Closed
fix: initialize model language filter from user preference (#1265)#1309ChristophNoetel wants to merge 1 commit into
ChristophNoetel wants to merge 1 commit into
Conversation
The Models settings page always showed all models regardless of the user's selected transcription language. Initialize the language filter dropdown from the user's selected_language setting so that models are pre-filtered to the relevant language on page load. When selected_language is "auto" or unset, the filter defaults to "all" (showing every model) which preserves the current behavior for users who haven't picked a specific language.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selected_languagesettingselected_languageis "auto" or unset, defaults to "All Languages" (preserves current behavior)Closes #1265
Details
The
ModelsSettingscomponent had a locallanguageFilterstate hardcoded to"all". This meant every time a user opened Settings > Models, they'd see all models in all languages -- even if they'd configured English-only transcription.The fix reads
selected_languagefromAppSettingsvia the existinguseSettingshook (same pattern asLanguageSelector.tsx) and uses it as the initial filter value. The dropdown still allows browsing models in other languages by manually changing the filter.Mapping:
"auto"/undefined->"all"(show everything);"en","de", etc. -> filter directly.Test plan