Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
=======================================
Coverage 81.55% 81.55%
=======================================
Files 77 77
Lines 9541 9541
Branches 1162 1162
=======================================
Hits 7781 7781
Misses 1568 1568
Partials 192 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
auvipy
requested changes
Apr 1, 2025
Member
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
We will need a modified PR on this
Author
|
Thanks for the speedy review!
Sure, happy to keep the ball rolling! What needs modifying? |
auvipy
requested changes
Apr 3, 2025
| @@ -1,4 +1,4 @@ | |||
| typing_extensions==4.12.2; python_version<"3.10" | |||
| typing_extensions>=4.12.2; python_version<"3.10" | |||
Member
There was a problem hiding this comment.
we can keep this as is and make the latest version available with python =>3.11
Member
There was a problem hiding this comment.
this was pinned only for python version under 3.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this tool!
This PR relaxes the dependency on
typing_extensions==to be a>=: tightly pinning this (very prevalent) package creates all kinds of issues when used in more complex environments. I didn't look deep enough, but it is likely this could be pinned to an even lower value, asParamSpecandTypeGuardhave been stable for some time.