Move use of typing_extensions into TYPE_CHECKING block#2283
Merged
auvipy merged 1 commit intocelery:mainfrom Apr 5, 2025
Merged
Move use of typing_extensions into TYPE_CHECKING block#2283auvipy merged 1 commit intocelery:mainfrom
auvipy merged 1 commit intocelery:mainfrom
Conversation
so that typing-extensions is not required at runtime
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2283 +/- ##
==========================================
- Coverage 81.60% 81.55% -0.06%
==========================================
Files 77 77
Lines 9540 9541 +1
Branches 1162 1162
==========================================
- Hits 7785 7781 -4
- Misses 1563 1568 +5
Partials 192 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- requirements/default.txt: Language not supported
- requirements/pkgutils.txt: Language not supported
Comments suppressed due to low confidence (1)
kombu/asynchronous/semaphore.py:16
- Ensure that the alias 'P' is used exclusively for type annotations. If any runtime code relies on 'P', its definition being limited to the TYPE_CHECKING block might lead to a NameError.
P = ParamSpec("P")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all (one) usage of
typing_extensionsinto aif TYPE_CHECKINGblock, so that thetyping-extensionspackage is not required at runtime.This might relate to #2281.
First-time contributor, sorry if I haven't followed the right contributing procedure.