Skip to content

Refactor: consolidate context data - Eligibility Unverified#3483

Merged
angela-tran merged 5 commits intomainfrom
refactor/consolidate-context-data--eligibility-unverified
Feb 12, 2026
Merged

Refactor: consolidate context data - Eligibility Unverified#3483
angela-tran merged 5 commits intomainfrom
refactor/consolidate-context-data--eligibility-unverified

Conversation

@angela-tran
Copy link
Member

Part of #3467

Consolidates the Eligibility Unverified copy to the UnverifiedView

@angela-tran angela-tran self-assigned this Feb 12, 2026
@angela-tran angela-tran requested a review from a team as a code owner February 12, 2026 00:40
@github-actions github-actions bot added i18n Copy: Language files or Django i18n framework tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. and removed tests Related to automated testing (unit, UI, integration, etc.) labels Feb 12, 2026
@github-actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core/models
  enrollment.py
  benefits/eligibility
  analytics.py
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@angela-tran angela-tran force-pushed the refactor/consolidate-context-data--eligibility-unverified branch from 6f7993b to fa8b650 Compare February 12, 2026 00:41
@angela-tran
Copy link
Member Author

This will have some conflicts with #3481, and I'm happy to wait for that one to be merged first. Whenever those changes are in main, I can rebase and remove the AGENCY_CARD entry from UnverifiedView.get_context_data.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Edit: #3481 already has conflicts that need to be addressed from some of these other changes, and I requested a few changes there anyway. I think we should merge as many of these smaller ones as possible knowing @Scotchester will be out until next Tuesday.

@angela-tran
Copy link
Member Author

I just noticed the same thing, so sounds good!

@angela-tran angela-tran merged commit 1af3913 into main Feb 12, 2026
14 checks passed
@angela-tran angela-tran deleted the refactor/consolidate-context-data--eligibility-unverified branch February 12, 2026 00:59
@thekaveman thekaveman linked an issue Feb 13, 2026 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

back-end Django views, sessions, middleware, models, migrations etc. i18n Copy: Language files or Django i18n framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move context into CBVs and remove context modules

2 participants