chore: Relax agency card form class check

[Scotchester]

Closes #3398

---

We no longer want to worry about matching agency slugs, only the flow's system_name. This will allow agencies to honor other agencies' programs.

Testing instructions

1. Update .devcontainer/server/settings.py to change IMPORT_FILE_PATH to https://raw.githubusercontent.com/cal-itp/eligibility-server/cd5fed032524e4753a97573a7caef6fa17ea398b/data/server.csv
2. Start the devcontainer (or restart the server container if it was already running)
3. Shell into the server container
4. Run flask drop-db followed by flask init-db
   • This is necessary because I believe there is not currently a way to tell the server container to reset its DB when starting up via the devcontainer.
   • You should see output for the second command looking like this:

     calitp@10c2a337d4b7:/calitp/app$ flask init-db
     [2026-02-11 19:59:01,483] WARNING eligibility_server.sentry:61 SENTRY_DSN not set, so won't send events
     [2026-02-11 19:59:01,483] INFO eligibility_server.app:33 Starting Eligibility Server 0.1.dev1+g12a60a598
     Creating table...
     Table created.
     Importing users from: https://raw.githubusercontent.com/cal-itp/eligibility-server/     cd5fed032524e4753a97573a7caef6fa17ea398b/data/server.csv
     [2026-02-11 19:59:01,496] DEBUG urllib3.connectionpool:1049 Starting new HTTPS connection (1): raw.githubusercontent.     com:443
     [2026-02-11 19:59:01,622] DEBUG urllib3.connectionpool:544 https://raw.githubusercontent.com:443 "GET /cal-itp/     eligibility-server/cd5fed032524e4753a97573a7caef6fa17ea398b/data/server.csv HTTP/1.1" 200 2150
     Users added: 26
     Eligibility types added: 1
     Database metadata updated.
     

5. Start the application and go through the CST Agency Cardholder flow, using standard Courtesy Card test data.

[github-actions]

This PR updates local_fixtures.json. After merging, please be sure to make a corresponding update to the fixtures with secrets in our shared LastPass folder and let other developers know that they should update their local fixtures accordingly.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
benefits/core
views.py					148
benefits/core/models
enrollment.py
benefits/eligibility
forms.py
views.py
benefits/enrollment
views.py
Project Total

This report was generated by python-coverage-comment-action

[thekaveman]

Hmm, I guess I didn't realize how far-reaching it would be to remove agency_card as an option from SystemName. Not that I disagree!

Part of the reason we set up CST was to have a "language neutral" agency for demos etc. that wouldn't favor/throw shade on a real agency, and this takes us away from that idea while majorly simplifying the overall codebase, so I think this is the right direction.

I'll just recommend that we also remove the CSTAgencyCard form and its associated copy as well, since it seems that is no longer relevant with these changes.

[jgravois]

nice work @Scotchester. i'm all for nuking agency_card. 💣

[jgravois]

my (slight) preference would be to reuse, but no offense taken if you disagree though.

its very unlikely that someone could change the variable above and miss this reference immediately below.

Suggested change

	expected_error_msg = "The senior flow does not support Eligibility API verification."
	expected_error_msg = f"The {view.flow.system_name} flow does not support Eligibility API verification."

[Scotchester]

Rebased and feedback addressed! Ready for final review.

[jgravois]

this code all looks reasonable to me, i didn't have any trouble running the migration locally. afterward the canned Agency card self-serve enrollment flow worked a treat 😄

Your card information may not have been entered correctly.

The number and last name must be entered exactly as they appear on your MST Courtesy Card. Please check your card and try again, or contact your transit agency for help.

https://github.com/cal-itp/eligibility-server/blob/6a26ce54d79c53f5a1f62bd96b13fe3326dccac8/data/server.csv#L2

i'm under the impression that is expected because the flow isn't configured correctly for e2e testing on main locally either.

we can confirm that all is still well on https://dev-benefits.calitp.org after merging. no offense taken if anyone else wants other eyes on this PR before you merge it though.

[Scotchester]

i'm under the impression that is expected because the flow isn't configured correctly for e2e testing on main locally either.

Did you follow the full set of testing instructions I put in the OP? No shame if you overlooked them, I just want to understand why they didn't work if you did.

[jgravois]

Did you follow the full set of testing instructions I put in the OP?

i did not and i disagree with you. shame on me! 🤦‍♂️

[jgravois]

RTFM and confirmed this works e2e. nice work @Scotchester 💪

Requested change has been made.

[Scotchester]

Thanks @jgravois! Could you also give this a review so I can merge them at the same time? cal-itp/eligibility-server#597

[angela-tran]

This looks good to me too. We just need @thekaveman's review and then will be good to go Oh nvm, didn't realize you could dismiss the review like that 😅

[Scotchester]

I'll hold on just the same to make sure he confirms I removed what he asked for :)

[thekaveman]

I didn't go through the QA steps, but my requested change was addressed!

Thanks everyone for the work on this 👍