[build] Use custom target for python package building#666
Open
trdthg wants to merge 1 commit intobuddy-compiler:mainfrom
Open
[build] Use custom target for python package building#666trdthg wants to merge 1 commit intobuddy-compiler:mainfrom
trdthg wants to merge 1 commit intobuddy-compiler:mainfrom
Conversation
5 tasks
trdthg
force-pushed
the
cmake-target-for-python
branch
from
fbf32bf to
4fe12ea
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The old foreach only ran once during cmake configuration. It couldn't detect the python file changes.
We should have a custom cmake target for building python package.
Checklist