refactor(vehicle): delegate vehicle interface launch to vehicle_launch pkg#1789
Draft
Autumn60 wants to merge 2 commits intoautowarefoundation:mainfrom
Draft
refactor(vehicle): delegate vehicle interface launch to vehicle_launch pkg#1789Autumn60 wants to merge 2 commits intoautowarefoundation:mainfrom
Autumn60 wants to merge 2 commits intoautowarefoundation:mainfrom
Conversation
…h.xml Signed-off-by: Autumn60 <harada.akiro@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Autumn60 <harada.akiro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a string argument
vehicle_launch_modetotier4_vehicle_launch'svehicle.launch.xmlto choose how vehicle-related launch is done.vehicle_interface(default)vehicle_interface.launch.xmlwhenlaunch_vehicle_interfaceis true.vehiclevehicle.launch.xmland passeslaunch_vehicle_interface(and other args). The vehicle package decides whether to start vehicle_interface and can run vehicle-specific logic (e.g. SteeringReport → JointState for articulated vehicles) with or without it.This enables launching vehicle-specific functionality without vehicle_interface, which is useful for articulated vehicles and especially for simulation, where vehicle_interface is usually not needed.
How was this PR tested?
vehicle_launch_mode="vehicle_interface": behavior matches the previous implementation.vehicle_launch_mode="vehicle": vehicle package'svehicle.launch.xmlis included and receives the intended arguments.Notes for reviewers
None.
Effects on system behavior
vehicle_interface; existing callers and vehicle packages require no change.vehicle_launch_mode="vehicle"to use a vehicle package'svehicle.launch.xml. That package must providelaunch/vehicle.launch.xmland handlelaunch_vehicle_interfaceas needed.