fix(autoware_downsample_filters): fix bugprone-narrowing-conversions warnings#937
Conversation
…warnings Signed-off-by: NorahXiong <norah.xiong@autocore.ai>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
NorahXiong
added
the
run:build-and-test-differential
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
=======================================
Coverage 50.41% 50.41%
=======================================
Files 367 367
Lines 22987 22987
Branches 10200 10200
=======================================
Hits 11588 11588
Misses 10281 10281
Partials 1118 1118
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NorahXiong
requested review from
a team,
YoshiRi,
amc-nu,
badai-nguyen,
drwnz,
knzo25,
kyoichi-sugahara,
liuXinGangChina,
meliketanrikulu,
mojomex,
vividf and
yukkysaito
as code owners
sasakisasaki
left a comment
sasakisasaki
left a comment
There was a problem hiding this comment.
@NorahXiong Thank you for your contribution. I have a quick question.
| voxel_size_x_(static_cast<float>(declare_parameter<double>("voxel_size_x"))), | ||
| voxel_size_y_(static_cast<float>(declare_parameter<double>("voxel_size_y"))), | ||
| voxel_size_z_(static_cast<float>(declare_parameter<double>("voxel_size_z"))), |
There was a problem hiding this comment.
If we do not apply this fix, does the clang-tidy show error?
There was a problem hiding this comment.
Yes. All fixes are due to clang-tidy check errors.
clang-tidy-18 -export-fixes /tmp/tmpkxq6xsd4/tmpur9c7ali.yaml -extra-arg-before=-Wno-unknown-warning-option -p=build/ --config-file=src/core/autoware_core/.clang-tidy-ci /autoware/src/core/autoware_core/sensing/autoware_downsample_filters/src/voxel_grid_downsample_filter/faster_voxel_grid_downsample_filter.cpp
/autoware/src/core/autoware_core/sensing/autoware_downsample_filters/src/voxel_grid_downsample_filter/faster_voxel_grid_downsample_filter.cpp:43:15: error: narrowing conversion from 'offset_type' (aka 'unsigned int') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions,-warnings-as-errors]
43 | x_offset = input->fields[pcl::getFieldIndex(*input, "x")].offset;
| ^
/autoware/src/core/autoware_core/sensing/autoware_downsample_filters/src/voxel_grid_downsample_filter/faster_voxel_grid_downsample_filter.cpp:44:15: error: narrowing conversion from 'offset_type' (aka 'unsigned int') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions,-warnings-as-errors]
44 | y_offset = input->fields[pcl::getFieldIndex(*input, "y")].offset;
| ^
/autoware/src/core/autoware_core/sensing/autoware_downsample_filters/src/voxel_grid_downsample_filter/faster_voxel_grid_downsample_filter.cpp:45:15: error: narrowing conversion from 'offset_type' (aka 'unsigned int') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions,-warnings-as-errors]
45 | z_offset = input->fields[pcl::getFieldIndex(*input, "z")].offset;
| ^
/autoware/src/core/autoware_core/sensing/autoware_downsample_filters/src/voxel_grid_downsample_filter/faster_voxel_grid_downsample_filter.cpp:58:25: error: narrowing conversion from 'offset_type' (aka 'unsigned int') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions,-warnings-as-errors]
58 | intensity_offset = input->fields[intensity_index_].offset;
| ^
/autoware/src/core/autoware_core/sensing/autoware_downsample_filters/src/voxel_grid_downsample_filter/faster_voxel_grid_downsample_filter.cpp:170:83: error: narrowing conversion from 'int' to 'float' [bugprone-narrowing-conversions,-warnings-as-errors]
170 | int ijk0 = static_cast(std::floor(point[0] * inverse_voxel_size_[0]) - min_voxel[0]);
| ^
/autoware/src/core/autoware_core/sensing/autoware_downsample_filters/src/voxel_grid_downsample_filter/faster_voxel_grid_downsample_filter.cpp:171:83: error: narrowing conversion from 'int' to 'float' [bugprone-narrowing-conversions,-warnings-as-errors]
171 | int ijk1 = static_cast(std::floor(point[1] * inverse_voxel_size_[1]) - min_voxel[1]);
| ^
/autoware/src/core/autoware_core/sensing/autoware_downsample_filters/src/voxel_grid_downsample_filter/faster_voxel_grid_downsample_filter.cpp:172:83: error: narrowing conversion from 'int' to 'float' [bugprone-narrowing-conversions,-warnings-as-errors]
172 | int ijk2 = static_cast(std::floor(point[2] * inverse_voxel_size_[2]) - min_voxel[2]);
| ^
7 warnings treated as errors
2 participants
Description
Step 2 of #774 (comment): Remove the exception from the .clang-tidy-ci list.
Related links
Parent Issue:
#774
How was this PR tested?
No clang-tidy error appears in CI.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.