Skip to content

jspecify and java update#10

Merged
SirCotare merged 16 commits into
mainfrom
enforce_jspecify
Jun 3, 2026
Merged

jspecify and java update#10
SirCotare merged 16 commits into
mainfrom
enforce_jspecify

Conversation

@SirCotare
Copy link
Copy Markdown
Member

@SirCotare SirCotare commented May 15, 2026

target: 2.0.0 (final)

known: readme is still out dated. won't fix now. this is built for our gradle integration

with usage example here: https://github.com/aboutbits/finstral-composer-api/pull/676

@SirCotare SirCotare self-assigned this May 15, 2026
@SirCotare

This comment has been minimized.

SirCotare

This comment was marked as resolved.

@ThoSap
Copy link
Copy Markdown
Member

ThoSap commented May 15, 2026

I would release 2.0.0 once we migrated this lib to use Gradle + Axion Release Plugin like https://github.com/aboutbits/postgresql-operator/blob/main/build.gradle.kts#L11-L29 does.

Also the readme.md needs some care.

@SirCotare SirCotare requested a review from ThoSap May 15, 2026 13:48
@SirCotare
Copy link
Copy Markdown
Member Author

I would release 2.0.0 once we migrated this lib to use Gradle + Axion Release Plugin like aboutbits/postgresql-operator@main/build.gradle.kts#L11-L29 does.

Also the readme.md needs some care.

ok.. so we stay on RC for now. just take a look it you think this and the usage are OK the way they are now

Copy link
Copy Markdown
Member

@ThoSap ThoSap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if our Checkstyle config allows this, but I would name all it.aboutbits.checkstyle.Jspecify* classes JSpecify.

Otherwise LGTM 👍🏼

Comment thread pom.xml Outdated
Comment thread pom.xml Outdated
Comment thread src/test/java/it/aboutbits/checkstyle/JSpecifyOnTopLevelTypesCheckTest.java Outdated
Comment thread src/main/resources/it/aboutbits/checkstyle/messages.properties
Co-authored-by: Riker <riker@riker.local>
@SirCotare SirCotare merged commit b4448f1 into main Jun 3, 2026
1 check passed
@SirCotare SirCotare deleted the enforce_jspecify branch June 3, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants