Add AssertJ 3.27.7 and replace JUnit assertions in tests#11
Merged
Conversation
SirCotare
added a commit
that referenced
this pull request
Jun 3, 2026
* add common code style config * update deps * add jspecify rules and ability for local suppressions file * add github test workflow * fix project config * fix project config * 2.0.0-RC3 * add tests and checks for custom annotations and improve validation * fully add jspecify and nullaway. cleanup some code too * 2.0.0-RC4 * fix dependency scope for jspecify * 2.0.0-RC5 * rename `Jspecify` classes and tests to `JSpecify`, update dependencies * rename test resources to align `Jspecify` with `JSpecify` formatting * Add AssertJ 3.27.7 and replace JUnit assertions in tests (#11) Co-authored-by: Riker <riker@riker.local> --------- Co-authored-by: AboutBits Tech <tech@aboutbits.it> Co-authored-by: Riker <riker@riker.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces all JUnit
Assertions.assertEquals/assertTruecalls in the four test classes with AssertJassertThat(...)equivalents, and addsassertj-core 3.27.7as a test dependency inpom.xml.Changes:
pom.xml— addsassertj.versionproperty andassertj-coretest dependencyJSpecifyAnnotationOrderCheckTest— converted to AssertJJSpecifyOnTopLevelTypesCheckTest— converted to AssertJJSpecifyMapStructMapperAnnotationCheckTest— converted to AssertJJSpecifyInlineTypeUseCheckTest— converted to AssertJAll 6 tests in
JSpecifyAnnotationOrderCheckTestverified green locally after the change.Parent PR: #10
CI runs full verification.