Skip to content

Add fcl configuration TwoBodyAnisotropyIncludeInterference to match s… #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bear-is-asleep merged 1 commit into from
Mar 10, 2025
Merged

Add fcl configuration TwoBodyAnisotropyIncludeInterference to match s… #657

bear-is-asleep merged 1 commit into from
Mar 10, 2025

Conversation

@LuisPelegrina
Copy link
Contributor

@LuisPelegrina LuisPelegrina commented Feb 21, 2025

Commit to match lastest changes to sbncode MeVprtlGen. The fhicl configuration parameter TwoBodyAnisotropyIncludeInterference is added. Not adding this parameter into the configuration fhicl makes the generator code to crash and not generate any input. ThreeBodyAnisotropies are also turned on by default.

The relevant sbncode pull request is:
SBNSoftware/sbncode#502

@LuisPelegrina LuisPelegrina added the enhancement New feature or request label Feb 21, 2025
@LuisPelegrina LuisPelegrina self-assigned this Feb 21, 2025
@LuisPelegrina LuisPelegrina mentioned this pull request Feb 21, 2025
Merged
@RachelCoackley
Copy link
Contributor

RachelCoackley commented Feb 28, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_03 SBNSoftware/sbnanaobj@v09_23_03 SBNSoftware/sbnobj@v10_00_04 SBNSoftware/sbncode@v10_04_03

@FNALbuild
Copy link
Collaborator

FNALbuild commented Feb 28, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Feb 28, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Feb 28, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Feb 28, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Mar 4, 2025 •
edited
Loading

Approved, sbncode PR is in a tagged release

@bear-is-asleep bear-is-asleep merged commit 5f36596 into develop Mar 10, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gputnam gputnam gputnam approved these changes

@jicrespo jicrespo Awaiting requested review from jicrespo

@jberger7 jberger7 Awaiting requested review from jberger7

Assignees

@LuisPelegrina LuisPelegrina

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LuisPelegrina @RachelCoackley @FNALbuild @bear-is-asleep @gputnam