Skip to content

Conversation

@LuisPelegrina
Copy link
Contributor

@LuisPelegrina LuisPelegrina commented Feb 6, 2025

In this request two main issues in the HNL part of MeVPrtlGen have been tackled:

  1. HNL Polarisation calculations have been revised:
    • Polarisation calculation are now also included in Tau decays into HNLs, using the same formula as the Kaon decays, and are implemented inside Tau2HNLFlux_tool.cc
    • A bug in the polarisation calculation in the Kaon case is now solved. K^{+}->l^{+}N and K^{-} -> l^{-N} where programmed to have the same polarisation instead of opposite. This now has been fixed inside the module Kaon2HNLFlux_tool.cc.
      2- The implementation of anisotropies in the l^{-/+}M^{+/-} decay is now implemented:
    • AnisotropicTwoBodyDecay.h and AnisotropicTwoBodyDecay.cpp have been added to handle anisotropic decay.
      • The main function is AnisotropicTwoBodyDist, which samples the integral that makes the decay anisotropic.
      • The integral sampled is given by: I = (1 -Pol) * I_{1}^{-}/2 + (1 + Pol) * I_{1}^{+)/2.
      • The function also changes the reference frame to correctly match the original formula in 1905.00284 in which the angle is given in respect to the HNL direction.
    • HNLMakeDecay_tool.cc has changed to include the anisotropic sampling. The boosting of the daughter particles is performed in this part of the code, the AnisotropicTwoBodyDist only gives the distribution in the HNL rest frame.
    • hnl.fcl (the config fhicl for HNL decays) has been changed to include a new boolean: DecayIsTwoBodyAnisotropic. This boolean lets the user choose between the old implementation (done by Gray) and the new one. It is turned true by default.

This pull request is linked to sbndcode pull request with link:
SBNSoftware/sbndcode#657

@LuisPelegrina LuisPelegrina added the enhancement New feature or request label Feb 6, 2025
Copy link
Contributor

@gputnam gputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made some comments about configuration.

…r rotation to HNL POl frame, implemented random with CLHEP::HepRandomEngine, changed DecayIsThreeBodyAnisotropic to true
@kjplows
Copy link
Contributor

kjplows commented Feb 26, 2025

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Succeeded with warning at phase build on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@kjplows kjplows merged commit fdd01c4 into develop Feb 27, 2025
3 of 6 checks passed
@kjplows kjplows moved this from Recently done to Done in SBN software development Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants